Found the following issue while writing the unit tests so updating the code as per the following change record
https://www.drupal.org/node/2444095

Error:
Detailed test results
---------------------

---- Drupal\multilingual_demo\Tests\MultilingualDemoMenuTest ----

Status Group Filename Line Function
--------------------------------------------------------------------------------
Fail Completion MultilingualDemoM 70 Drupal\multilingual_demo\Tests\Mult
The test did not complete due to a fatal error.
Exception Uncaught e ConfigSchemaCheck 98 Drupal\Core\Config\Testing\ConfigSc
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
user.settings with the following errors: user.settings:admin_role missing

CommentFileSizeAuthor
#7 multilingual_demo-updating-the-code-as-per-change-record-2650324-7-8.x.patch577 bytesmimran
#2 multilingual_demo-updating-the-code-as-per-change-record-2650324-2-8.x.patch668 bytesmimran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mimran created an issue. See original summary.

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
FileSize
multilingual_demo-updating-the-code-as-per-change-record-2650324-2-8.x.patch668 bytes

Updated the code with the patch

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Assigned: mimran » Unassigned
mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Active » Needs review
mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Title: setting the administrator role as per the change record » user.settings:admin_role missing when running the automated tests
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Needs work

is_admin: true is already present in multilingual_demo/config/install/user.role.administrator.yml, so not sure what does the new code achieve?

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Needs work » Needs review
FileSize
multilingual_demo-updating-the-code-as-per-change-record-2650324-7-8.x.patch577 bytes

Thanks for your reply @Hojtsy , yes you are correct is_admin flag is properly set in the mentioned file but system is looking for a flag admin_role in core/modules/user/config/install/user.settings.yml which is removed as per the following change record https://www.drupal.org/node/2444095 so no point to set that in multilingual_demo_install() updating the patch by removing that i would love to here your thoughts as well on this

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

How does this solve your test problem then?

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented

test was failed because of that piece of out dated code after removing that it worked fine

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

All right, let's get this in.

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented

@GáborHojtsy Thanks

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

  • Gábor Hojtsy committed ad14ed7 on 8.x-1.x 
    Issue #2650324 by mimran: user.settings:admin_role missing when running...
mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Updating attribution.