MSG91 SMS module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#5 short_array_syntax-2870334-3.patch3.81 KBpk188
#3 short_array_syntax-2870334-3.png86.48 KBamit.drupal
#2 short_array_syntax-2870334-2.patch3.87 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2870334-2.patch3.87 KB
amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
short_array_syntax-2870334-3.png86.48 KB

Patch #2 applied cleanly. All the arrays converted to short array syntax.
Checked it manually.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community

Changing status to RTBC

pk188’s picture

pk188 CreditAttribution: pk188 at OpenSense Labs commented
Status: Reviewed & tested by the community » Needs review
FileSize
short_array_syntax-2870334-3.patch3.81 KB

#2 was not applied. So, i re rolled it.

pritish.kumar’s picture

pritish.kumar CreditAttribution: pritish.kumar at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Status: Reviewed & tested by the community » Fixed
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.