The main module file, mpac.module, has Windows-style line endings (\r\n) instead of Unix-style (\n) (Coding standards reference).

Patch against 7.x.-1.x-dev attached.

(I am going to post a proposed feature patch later and wanted to clean this up first, to avoid creating a mess.)

CommentFileSizeAuthor
#1 code_style_cleanup-15416778-2--6.patch4.55 KBstborchert
#1 code_style_cleanup-15416778-2--7.patch15 KBstborchert
0001-Fix-Windows-style-line-endings-in-mpac.module..patch15.3 KBDrave Robber

Comments

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new code_style_cleanup-15416778-2--7.patch15 KB
new code_style_cleanup-15416778-2--6.patch4.55 KB

Hm, strange. I've no idea why the file contains windows line-endings. I'm developing on a Mac :)

I've created 2 patches containing a) the line-ending change and b) some code style cleanup (noticed by Coder).

Drave Robber’s picture

Drave Robber commented

7 looks good.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Fixed

Committed to 7.x-1.x and 6.x-1.x.

Thanks for the hint.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

clarified which branch the patch is against.