got this notice in a clean drupal after activating the mothership theme.

CommentFileSizeAuthor
#5 Screen Shot 2012-05-30 at 1.20.45 PM.png62.96 KBadnasa
template-fix.patch886 bytesloominade
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Needs review » Fixed

foxed

adnasa’s picture

adnasa CreditAttribution: adnasa commented

I just installed the theme on a fresh copy of drupal.
notice remains.

adnasa’s picture

adnasa CreditAttribution: adnasa commented
Status: Fixed » Needs work

changed status

mortendk’s picture

mortendk CreditAttribution: mortendk commented

which version & page
a screenshot or something ?

adnasa’s picture

adnasa CreditAttribution: adnasa commented
FileSize
Screen Shot 2012-05-30 at 1.20.45 PM.png62.96 KB

Latest stable version 7.x-2.6 I downloaded recently.
I don't think a screenshot is needed, since it is the exact same notice as discussed earlier.

but if you insist

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Version: 7.x-2.2 » 7.x-2.6
RobW’s picture

RobW CreditAttribution: RobW commented

Getting the same.

konsumer’s picture

konsumer CreditAttribution: konsumer commented

I am getting notices like this for everywhere that these sort of checks are not being used, for example:

Notice: Undefined index: header in include() (line 24 of SECRET_PATH/webroot/sites/all/themes/contrib/mothership/mothership/templates/page--404.tpl.php).

The solution is to use code like this:

if (empty($thing)){
}

Instead of

if ($thing){
}

I recommend changing the issue title to "Notices on undefined indexes", as it is a larger, but easily fixable issue.

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Needs work » Postponed (maintainer needs more info)

cant reproduce this issue :/