Problem/Motivation

Drush 13 complains (and doesn't run when assertions are on) if you set $this->logger in a command.

Proposed resolution

Don't inject a logger channel and let Drush do its default logging behaviour (I guess just logging to the console).

The issup_moodle channel won't make much sense for anyone apart from me, anyway!

Issue fork moodle_rest-3562494

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jacktonkin created an issue. See original summary.

jacktonkin opened merge request !8

jacktonkin’s picture

jacktonkin commented
Assigned: jacktonkin » Unassigned
Status: Active » Needs review
gaddman’s picture

gaddman commented
Status: Needs review » Reviewed & tested by the community

Tested and resolves the issue for me. Regarding issup_moodle, that's still used in moodle_rest_user/src/UserBatchHelper.php, but cleaning that up is probably best done as part of issue #3532546 to support Drupal 11 and remove calls to watchdog_exception.

gaddman’s picture

gaddman commented

Ignore the comments about issup_moodle, that's already fixed in the dev branch.