Problem/Motivation

The icinga code is partially ported but still incomplete / broken.
Either we support it and complete it or we drop it.

Proposed resolution

Drop it for now. Readd it when someone completed it.

Remaining tasks

User interface changes

API changes

Comments

miro_dietiker’s picture

Status: Active » Needs review
StatusFileSize
new39.08 KB

Providing a first patch to bulk remove.

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Ok with removing it, what about keeping the issue open if someone needs it and wants to port it?

miro_dietiker’s picture

Title: Drop or complete icinga integration » Readd icinga integration
Component: Integration - Munin » Integration - Icinga
Priority: Normal » Minor
Status: Reviewed & tested by the community » Active

Yeah. Committed the removal.
Changing issue title to readd it, setting active. Not a priority for now since services are.

  • miro_dietiker committed 07525bc on 8.x-1.x
    Issue #2398835 by miro_dietiker: Drop icinga integration, it is a...
plopesc’s picture

Status: Active » Needs review
StatusFileSize
new23.99 KB

Hello,

Here I'm attaching a first iteration to re-add the Monitoring Icinga submodule to the monitoring suite.

This is just a straight migration form the exisiting D7 version to D8. It has been tested and it works in our stack.

Would be great if you take a look into this patch and provide some feedback.

If you are not interested in including this module back, I could create a new separated project to avoid you to take care of it.

Thank you in advance.

plopesc’s picture

StatusFileSize
new10.87 KB
new32.87 KB

Posting a new iteration of the patch, adding the README file I forgot to add in the previous one and some minor improvements to the drush command when using the active connector.

plopesc’s picture

StatusFileSize
new2.58 KB
new31.83 KB

Here is a new updated version of the patch, improving a bit the docs and removing unrelated changes in monitoring.module file.

miro_dietiker’s picture

Great to see activity here.

+++ b/modules/monitoring_icinga/README.txt
@@ -0,0 +1,187 @@
+ * Drupal xautoload module to utilise namespaces

Likely not with D8. :-)

Unsure yet if it makes sense to add it to Monitoring itself as we don't use icinga anymore. Likely not a candidate without any test coverage at all. Will provide more feedback after some deep thoughts.

berdir’s picture

Yeah, I'm also thinking it might be better to do this as a separate project as we no longer use icinga. Happy to add a link to the project page.

plopesc’s picture

As you suggested, I created a new standalone project for Icinga: https://www.drupal.org/project/monitoring_icinga

We can close this issue and I will create a new one with the changes in monitoring.links.task.yml, to allow to link both projects together in the admin page.

Thank you