Problem/Motivation
The icinga code is partially ported but still incomplete / broken.
Either we support it and complete it or we drop it.
Proposed resolution
Drop it for now. Readd it when someone completed it.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2398835-7.patch | 31.83 KB | plopesc |
| #7 | interdiff.txt | 2.58 KB | plopesc |
| #6 | 2398835-6.patch | 32.87 KB | plopesc |
| #6 | interdiff.txt | 10.87 KB | plopesc |
| #1 | monitoring_2398835_icinga.patch | 39.08 KB | miro_dietiker |
Comments
Comment #1
miro_dietikerProviding a first patch to bulk remove.
Comment #2
berdirOk with removing it, what about keeping the issue open if someone needs it and wants to port it?
Comment #3
miro_dietikerYeah. Committed the removal.
Changing issue title to readd it, setting active. Not a priority for now since services are.
Comment #5
plopescHello,
Here I'm attaching a first iteration to re-add the Monitoring Icinga submodule to the monitoring suite.
This is just a straight migration form the exisiting D7 version to D8. It has been tested and it works in our stack.
Would be great if you take a look into this patch and provide some feedback.
If you are not interested in including this module back, I could create a new separated project to avoid you to take care of it.
Thank you in advance.
Comment #6
plopescPosting a new iteration of the patch, adding the README file I forgot to add in the previous one and some minor improvements to the drush command when using the active connector.
Comment #7
plopescHere is a new updated version of the patch, improving a bit the docs and removing unrelated changes in monitoring.module file.
Comment #8
miro_dietikerGreat to see activity here.
Likely not with D8. :-)
Unsure yet if it makes sense to add it to Monitoring itself as we don't use icinga anymore. Likely not a candidate without any test coverage at all. Will provide more feedback after some deep thoughts.
Comment #9
berdirYeah, I'm also thinking it might be better to do this as a separate project as we no longer use icinga. Happy to add a link to the project page.
Comment #10
plopescAs you suggested, I created a new standalone project for Icinga: https://www.drupal.org/project/monitoring_icinga
We can close this issue and I will create a new one with the changes in monitoring.links.task.yml, to allow to link both projects together in the admin page.
Thank you