After making the switch from MoneyScripts to MoneySuite, we encountered issues with recurring Paypal purchases using Paypal WPS. The purchase would never seem to complete and the user would be left looking at the spinning gif on the payment page.

It turns out, after much investigation, that MoneySuite was looking for a field called mc_amount3 in the IPN notification. That field, however, was missing. Therefore, the incoming amount was reported as zero, the IPN value didn't match the order value and the IPN failed validation.

I've patched MoneySuite to allow for the field that _was_ present: mc_gross, in addition to the existing fields. I'm attaching a patch.

CommentFileSizeAuthor
#2 2878458_paypal_ipn_mc_gross_field.patch1.35 KBanthonylindsay

Comments

anthonylindsay created an issue. See original summary.

anthonylindsay’s picture

anthonylindsay commented
StatusFileSize
new 2878458_paypal_ipn_mc_gross_field.patch1.35 KB
hockey2112’s picture

hockey2112 commented

Hi anthonylindsay, I tried your patch but I am still receiving the the never-ending "Your order is being processed. Please allow up to 2 minutes for this process to complete. Thank you for your patience." message. In Firebug, I see this error occurring again and again:

https://mywebsite.com/?q=ms_paypal_wps/check_ipn_status/BbLttSwcUXzYyF6v...

Response: {"result":"failure"}

Any ideas on how I can fix this? Thanks!

vaccinemedia’s picture

vaccinemedia commented

@hockey2112 can you apply the patch here: https://www.drupal.org/node/2730149 and let me know if this fixes the issue? It's probably hanging because validation isn't passing. After applying the above Paypal works with single payments where it wasn't before.

Farreres’s picture

Farreres commented

I am not yet applying this patch as some because there was no reply confirming the patch corrects the issue.

kebne’s picture

kebne commented

Seems like this patch found its way into the repos? But both the line which should be replaced and the new line is existing in both the current version and the dev:

 $recurring_schedule = array(
        'total_occurrences' => (isset($ipn['recur_times'])) ? $ipn['recur_times'] : 0,
        'main_amount' => isset($ipn['mc_amount3']) ? $ipn['mc_amount3'] : isset($ipn['amount3']) ? $ipn['amount3'] : 0,
	'main_amount' => isset($ipn['mc_gross']) ? $ipn['mc_gross'] : isset($ipn['mc_amount3']) ? $ipn['mc_amount3'] : isset($ipn['amount3']) ? $ipn['amount3'] : 0,
        //'main_length' => $main_period[0],
        'main_unit' => $main_period[1],
        'has_trial' => ($trial_period[0]) ? TRUE : FALSE,
        'trial_amount' => isset($ipn['mc_amount1']) ? $ipn['mc_amount1'] : isset($ipn['amount1']) ? $ipn['amount1'] : 0,
        'trial_length' => $trial_period[0],
        'trial_unit' => $trial_period[1],
      );
Farreres’s picture

Farreres commented

Patching as soon as it is marked as Reviewed & tested by the community.

zorbtrauts’s picture

zorbtrauts commented

I'm running into this issue, as well. Does this patch need to be tested or is it being committed?