The code still calls deprecated methods. Those calls need to be removed.

CommentFileSizeAuthor
#11 interdiff_8-11.txt2.4 KBswatichouhan012
#11 2792265-11.patch3.8 KBswatichouhan012
#8 interdiff_4_8.txt1.11 KBNotifyOne
#8 2792265-add-to-string-method-1.patch1.91 KBNotifyOne
#4 2792265.deprecation.4.patch1.75 KBeshta
#2 2792265-2.patch1.73 KBPradnya Pingat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pradnya Pingat created an issue. See original summary.

Pradnya Pingat’s picture

Pradnya Pingat CreditAttribution: Pradnya Pingat at Blisstering Solutions commented
Assigned: Pradnya Pingat » Unassigned
Status: Active » Needs review
FileSize
2792265-2.patch1.73 KB

Please find the patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: 2792265-2.patch, failed testing.

eshta’s picture

eshta CreditAttribution: eshta at Acquia commented
Status: Needs work » Needs review
FileSize
2792265.deprecation.4.patch1.75 KB

re-rolled patch

Status: Needs review » Needs work

The last submitted patch, 4: 2792265.deprecation.4.patch, failed testing.

nginex’s picture

nginex CreditAttribution: nginex at Drupal Ukraine Community commented
Issue tags: +LutskGCW20

Tagging for Drupal Global Contribution Weekend

NotifyOne’s picture

NotifyOne CreditAttribution: NotifyOne commented
Assigned: Unassigned » NotifyOne
NotifyOne’s picture

NotifyOne CreditAttribution: NotifyOne commented
Assigned: NotifyOne » Unassigned
Status: Needs work » Needs review
FileSize
2792265-add-to-string-method-1.patch1.91 KB
interdiff_4_8.txt1.11 KB

Added toString method for link. drupal_set_message not accepts Link class

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs review » Needs work
Issue tags: -drupal8
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: Removed deprecated method l from code base » Removed the calls to deprecated methods
Issue summary: View changes
Issue tags: -deprecated +Drupal 9 compatibility
swatichouhan012’s picture

swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented
Status: Needs work » Needs review
FileSize
2792265-11.patch3.8 KB
interdiff_8-11.txt2.4 KB

I have removed some deprecated code.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: Removed the calls to deprecated methods » Remove the calls to deprecated methods

The title was supposed to be corrected to Remove the calls to deprecated methods.