Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

Assigned: xaiwant » Unassigned
Status: Needs work » Needs review
FileSize
2.07 KB

Applied latest patch by fixing spelling error in module configuration page and configuration path

$items['admin/config/system/modules-weight/configration'] = array(

xaiwant’s picture

Issue tags: +Novice
xaiwant’s picture

swarad07’s picture

Status: Needs review » Needs work

Hi @Xaiwant,

The patch is good, but there are many coding standard issues that can be fixed.

Let me reroll the patch against latest 7.x-1.x with these fixes

swarad07’s picture

Status: Needs work » Needs review
FileSize
3.67 KB

Here you go,

I have taken this opportunity to make the module coder compatible along with the patch provided in #2 for addressing the issue.

Thanks for the patch @xaiwant!

swarad07’s picture

Component: Documentation » Code
FileSize
2 KB

Attaching a inter diff.

Sonal.Sangale’s picture

Assigned: Unassigned » Sonal.Sangale
Status: Needs review » Reviewed & tested by the community
snehi’s picture

+++ b/modules_weight.module
@@ -36,6 +35,13 @@ function modules_weight_menu() {
+ * ¶

Why empty space here
?

snehi’s picture

  1. +++ b/modules_weight.module
    @@ -94,6 +100,12 @@
    + * ¶
    

    Empty space.

snehi’s picture

Attaching patch and interdiff.

  • adriancid committed 3f388f8 on 7.x-1.x authored by snehi
    Issue #2621218 by swarad07, snehi, xaiwant, adriancid: Spelling errors...

adriancid’s picture

Status: Reviewed & tested by the community » Fixed

thanks @all for the work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.