Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Spelling errors in .module file and also in configuration file path
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff.txt | 466 bytes | snehi |
#11 | modules_weight-fix_coding_standard_nd_spell-2621218-11.patch | 3.67 KB | snehi |
#7 | interdiff-2621218-2-6.txt | 2 KB | swarad07 |
#6 | modules_weight-fix_coding_standard_nd_spell-2621218-6.patch | 3.67 KB | swarad07 |
#2 | 2621218-2.patch | 2.07 KB | xaiwant |
Comments
Comment #2
xaiwant CreditAttribution: xaiwant as a volunteer and at Valuebound commentedApplied latest patch by fixing spelling error in module configuration page and configuration path
$items['admin/config/system/modules-weight/configration'] = array(
Comment #3
xaiwant CreditAttribution: xaiwant as a volunteer and at Valuebound commentedComment #4
xaiwant CreditAttribution: xaiwant as a volunteer and at Valuebound commentedComment #5
swarad07Hi @Xaiwant,
The patch is good, but there are many coding standard issues that can be fixed.
Let me reroll the patch against latest 7.x-1.x with these fixes
Comment #6
swarad07Here you go,
I have taken this opportunity to make the module coder compatible along with the patch provided in #2 for addressing the issue.
Thanks for the patch @xaiwant!
Comment #7
swarad07Attaching a inter diff.
Comment #8
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedComment #9
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedWhy empty space here
?
Comment #10
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedEmpty space.
Comment #11
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedAttaching patch and interdiff.
Comment #15
adriancidthanks @all for the work.