SQL errors after upgrading Module Grants when also using Views and Coherent Access

I said my SQL is rubbish but I should have noticed the "AND ()" that was a fairly obvious culprit.

My bad for overriding your issue settings changes... simultaneous posting.

Tracking the empty AND looks like it's module_grants.module line 608:

$grants[] = "(". $lenient_subquery ."(SELECT COUNT(1) FROM {node_access} nasq WHERE na.nid=nasq.nid AND ($module_grants)) > 0)";

$module_grants var is perhaps empty? On line 604 there is an if statement: if (!empty($module_grants)) but this is closed before line 608:

600: foreach ($all_grants as $module => $module_grants) {
601: $lenient_subquery = '';
602: if (variable_get('module_grants_lenient', TRUE)) {
603: $module_realms = array_keys(module_invoke($module, 'node_grants', $account, $op));
604: if (!empty($module_grants)) {
605: $lenient_subquery = "(SELECT COUNT(1) FROM {node_access} nasq WHERE $node_access_alias.nid=nasq.nid AND realm IN ('". implode("','", $module_realms) ."')) = 0 OR ";
606: }
607: }
608: $grants[] = "(". $lenient_subquery ."(SELECT COUNT(1) FROM {node_access} nasq WHERE na.nid=nasq.nid AND ($module_grants)) > 0)";
609: }

Would replacing line 608 with the following fix it?

$module_grants_subquery = '';
if (!empty($module_grants)) {
$module_grants_subquery = "(SELECT COUNT(1) FROM {node_access} nasq WHERE na.nid=nasq.nid AND ($module_grants)) > 0";
}
if (!empty($lenient_subquery) || !empty($module_grants_subquery)) {
$grants[] = "(". $lenient_subquery .$module_grants_subquery .")";
}

In Site configruation >> Module Grants config page: Interpret absence of access grants as a "don't care", rather than a "deny access". is ticked.

Yes using OG and OG Access, but node getting error on is not a Group Post. For good measure unchecked all OG modules rebuilt perms. Still get empty 'AND' SQL error.

FYI also using Workflow and Workflow Access, if it helps for the node in question:

node_access entries for nodes shown on this page								
node	prio	status	realm	gid	view	update	delete	explained
200	– 	ok	workflow_access	1	1	0	0	
200	– 	ok	workflow_access	2	1′	0	0	
200	– 	empty	workflow_access	3	0	0	0	
200	– 	empty	workflow_access	4	0	0	0	
200	– 	empty	workflow_access	5	0	0	0	
200	– 	empty	workflow_access	6	0	0	0	
200	– 	empty	workflow_access	7	0	0	0	
200	– 	empty	workflow_access	8	0	0	0	
200	– 	empty	workflow_access	9	0	0	0	
200	– 	empty	workflow_access	10	0	0	0	
200	– 	empty	workflow_access	11	0	0	0	
200	– 	empty	workflow_access_owner	1	0	0	0

I also unchecked Workflow and Workflow Access and rebuilt permissions, but still get the error.

dpm($module_grants) I get the following:

*
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')
*
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')
* 
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')
* 
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')
*
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')
*
* (gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner')
* (gid=0 AND realm='og_public')

Empty culprit is coherent access module: http://drupal.org/project/coherent_access

Funnily enough after all that messing about I'm now getting another error:

....(((SELECT COUNT(1) FROM node_access nasq WHERE na.nid=nasq.nid AND realm IN ('coherent_access')) = 0 OR ) AND ((SELECT COUNT(1)....

Missing something after ('coherent_access')) = 0 OR ?????.

Ah... that is because I changed line 604 to if (!empty($module_realms)) { so its now actually writing the lenient subquery, but then missing the module_grants bit because that's empty for coherent access.