Thanks for all the work on getting a D7 version out. This module has great value because of the AND access permissions functionality it provides. I'm using it on many sites for OG and TAC combined access.

Tiny little change. The modules page does not show a Configure link since the page is not defined in the info file. Marking as bug just for attention and cos it's such small change that makes life a lot easier.

CommentFileSizeAuthor
#1 module_grants-add_configure_link-2379467-0.patch770 bytestinker

Comments

tinker’s picture

tinker commented
StatusFileSize
new module_grants-add_configure_link-2379467-0.patch770 bytes
izmeez’s picture

izmeez commented
Status: Active » Needs work

The patch does not apply. In the patch there is an erroneous line

\ No newline at end of file

in the middle.

However, adding the line you suggest

configure = admin/config/system/module_grants

does add the configure link to the modules page.

If you can re-roll the patch I can test it and mark it as RTBC.
Thanks.

tinker’s picture

tinker commented
Status: Needs work » Needs review

@izmeez did you apply this patch against 7.x-1.x-dev? I just ran two tests pulling latest source twice, and applying patch using 'git apply' and 'git am', both of which worked. The module_grants.info file does not have a newline so this patch should apply.

izmeez’s picture

izmeez commented

No, I did it without git.

In the module directory "wget" to fetch the patch and then "patch -p1 <" to apply.
Why does the patch have that line in it anyway?

Haven't had that with patches I've created using git and can apply them on non-git platforms.

Anyway, the fix you provide does what it says and if it is committed all's well.

Thanks.

izmeez’s picture

izmeez commented

oh, and yes I am applying it to 7.x-1.x-dev

tinker’s picture

tinker commented

@izmeez, You probably downloaded the 7.x-1.x-dev release from the module_grants project page. That release is old and contains packing script lines that are not in the GIT version. When applying patches you should always use the latest GIT code from the Version Release tab. That line is in there for cosmetic code format reason. Drupal code standards recommend having a blank new line at the end of each file and the line indicates that there was no newline in the source which causes the patch to add one.

izmeez’s picture

izmeez commented
Status: Needs review » Reviewed & tested by the community

@tinker Thanks. Yes It was the release from the project page.
As you said at the beginning the fix you have provided is a small fix that does what is intended.
I am changing the status to RTBC.