The "Enabled" column's "Off | On" slider UI widget is unreadable in IE11. It has no red/green color, just gray. White "On" or "Off" text is impossible to read on light gray button.

CommentFileSizeAuthor
#7 _module_filter-switch-state-is-unreadable-in-IE10-plux-2381201-7.x.-2.x.patch3.11 KBsilverham
#3 screenshot-20150223-74x38.png783 bytesvls
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guerno’s picture

guerno CreditAttribution: guerno commented

test

maori’s picture

maori CreditAttribution: maori commented

Same for me here

vls’s picture

vls CreditAttribution: vls commented
FileSize
screenshot-20150223-74x38.png783 bytes

It also cuts off the last F on the word "OFF" in both Firefox and Chrome.
This is with module_filter version 7.x-2.0.
This is on FreeBSD but I don't know if that will make a difference.

This is a nice module but I am curious what browsers was it tested on before release if it does not render correctly in IE, Firefox, or Chrome.

Ante890’s picture

Ante890 CreditAttribution: Ante890 commented

The js ON/OFF switch should be disabled by default. It adds nothing of value imo.

greenSkin’s picture

greenSkin CreditAttribution: greenSkin commented
Priority: Normal » Major

For power users, feel free to disable the ON/OFF switch on Module Filter's configuration page. There is the hope to one day provide an AJAX solution when flipping a switch that will enable/disable the module right then. For now, the switch is purely cosmetic.

The weird font issue where the F is pushed off is likely related to either the theme in use or something with the system such as an incompatible font. If you are familiar enough with your browser's dev tools, try inspecting the switch and setting it's font-family to "'Lucida Grande', 'Lucida Sans Unicode', sans-serif;". See if that makes a difference. If you could open a separate issue concerning the font, I'd be happy to pursue it further there.

Firefox, Safari, and Chrome have each been tested (on Mac) and perform as expected.

Pertaining directly to the original issue, it appears IE has issues with the linear gradient style. Will need to pursue a backwards (aka IE) compatible solution.

greenSkin’s picture

greenSkin CreditAttribution: greenSkin commented
Title: Enabled "slider" is unreadable in IE11 » Switch state is unreadable in IE10+
silverham’s picture

silverham CreditAttribution: silverham commented
FileSize
_module_filter-switch-state-is-unreadable-in-IE10-plux-2381201-7.x.-2.x.patch3.11 KB

The CSS linear-gradient syntax seems incorrect. This quick mockup works on IE11 on mine,

silverham’s picture

silverham CreditAttribution: silverham commented
Status: Active » Needs review
vls’s picture

vls CreditAttribution: vls commented

Hi silverham.

I am not clear as to whether this patch was only intended to affect Internet Explorer, but I went ahead and tested it with firefox 47.0.1 on FreeBSD 10.3. I just thought I would let you know I saw no visible change. The second 'F' is still cut off.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented

The 2 year old patch in #7 to module_filter_tab-rtl.css and module_filter_tab.css applied cleanly to the latest module_filter 7.x-2.x-dev, but still needs review as well as the comment #9 addressed.

Applied patch css/module_filter_tab-rtl.css cleanly.
Applied patch css/module_filter_tab.css cleanly.
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Closed (outdated)

Unfornately this missed the IE boat. Closing as outdated since IE is no more.