Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi,
I am translated this module to hungarian then found a few string cannot translate. I made a patch to amend the admin settings form.
Comment | File | Size | Author |
---|---|---|---|
#1 | modr8_admin.inc_.patch | 2.02 KB | Denes.Szabo |
Comments
Comment #1
Denes.Szabo CreditAttribution: Denes.Szabo commentedSorry, I left the patch.
Comment #2
pwolanin CreditAttribution: pwolanin commentedtypo is fixed.
The others strings are user-entered text, and hence should not be passed through t().
Comment #3
pwolanin CreditAttribution: pwolanin commentedsee http://drupal.org/node/606804 re: i18n issues
Comment #4
Denes.Szabo CreditAttribution: Denes.Szabo commentedSorry, but I do not agree with you. These strings are for default values for the email parts. These runs once, first time when you enter into the admin page.
So, when I enter the admin page on my hungarian drupal site, I got there an english text by default. If I change anything there these changes will be stored in the variables. Nothing in connection with the t() or tt().
So, the default values not user entered text, I think.
Comment #5
pwolanin CreditAttribution: pwolanin commentedHm, ok -I see your point - we want the default to be translated.