I just upgraded to Modernizr 7.x-3.5. It told me I needed to download a new copy of the script, which should include the css_boxsizing test. So I clicked the button, downloaded the recommended custom build and saved it to /sites/all/libraries/modernizr/modernizr.min.js. This is the only copy of the modernizr script in my libraries folder. The script header reads:
/*! modernizr 3.0.0 (Custom Build) | MIT *
* http://modernizr.com/download/?-boxsizing !*/
No matter how many times I refresh the cache, or what I name that file, the Modernizer status always throws the error:
Modernizr Tests Tests are missing in current Modernizr build.
Certain tests requested by currently enabled modules and themes are not within the current Modernizr build. Go to the Modernizr settings page to download a new version of Modernizr. The tests that are missing are: css_boxsizing
However, when I load a page on my site and look at the code, I see that my modernizer script is loading and the boxsizing
class appears in the html element, so some part of the module must recognize that the script is there. It's just confused.
Comment | File | Size | Author |
---|---|---|---|
#3 | Modernizr-detection.png | 64.22 KB | jstoller |
#2 | 2576457-1-regex-fix.patch | 602 bytes | rupl |
Comments
Comment #2
ruplThanks for the thorough bug report! Yup, I missed one tiny char in our silly regex that reads out these tests.. They switched from a
#
to a?
in the build URL.Can you test this patch and RTBC the issue before I commit? I want to make sure I get this right before cutting another release.
Comment #3
jstollerIt still seems to be doing something weird. See the image.
Comment #4
ruplDid you specify the
css_boxsizing
test somewhere else in your code? I did a quick scan of all the modules that implement the drupal module's API and I couldn't find one that implements that test: #1914478: [meta] Provide Modernizr integration for other contrib modulesOn a fresh drupal install my patch seems to work, so if you take one more look and can't find it I'll reclassify this as support and commit that patch.
Comment #5
ruplOk, fix has been pushed and the issue reclassified.
Comment #7
jstollerIt looks like my custom theme was requesting "css_boxsizing." That must have been the name of the test in an earlier version of Modernizr. Changing it to "boxsizing" fixes the problem.
Comment #8
ruplCool, good to hear. Thanks again for filing this, it was a small issue but rendered the admin config completely useless. 7.x-3.6 is published now so you can commit the latest version of the module to your codebase and it should all be back in order.
Comment #9
ruplSetting proper version now that the tag exists.