As per issue title. The whole div with class="download-modernizr" + the paragraph that follows it are repeated twice (once above and once below the modernizr-tests section) on the 'Rebuild Modernizr' tab (under ../admin/config/development/modernizr).

Or is this intentional for some reason?

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Issue summary: View changes
rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented
Status: Active » Closed (works as designed)

Good question. Yes, it's intentional for cases where someone has a very long list of Modernizr tests and/or utilities. I thought maybe someone will review their list line by line, and the button is there at the bottom when they finish.

The two buttons (and descriptions) are generated by one piece of code, but I just add it twice to the render array.

Marking this "works as designed" because that is true, but I don't mean to halt the conversation. If there is a problem with it, or you can envision a better way to do this, I'm open to some discussion!

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

I thought it must be intentional, just wanted to make sure. No big issue there (that's why I set the issue priority to 'minor' when I filed it after all). Still, not perfect and my OCD kicks in :P

Some modules like module_filter solve similar problems with long lists by having the respective form submit/save button be sticky at the bottom or top of the page as you scroll ("stickiness" enabled only if page height is longer than view and scrollbars start to show).