Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have just upgraded to the lastest version. With Firefox I have no problems, but IE8 gives me following error report:
Message: Object doesn't support this property or method
Line: 605
Char: 7
Code: 0
URI: http://localhost/drupal/sites/all/modules/modalframe/js/parent.js?n
Comments
Comment #1
markus_petrux CreditAttribution: markus_petrux commentedCould you please disable javascript compression and report back the line number where this error occurs?
Comment #2
tomsm CreditAttribution: tomsm commentedWhere do I disable this compression? Do you mean at the Drupal Performance tab?
The error is the same with everything turned off:
Message: Object doesn't support this property or method
Line: 605
Char: 7
Code: 0
URI: http://localhost/drupal/sites/all/modules/modalframe/js/parent.js?f
Comment #3
markus_petrux CreditAttribution: markus_petrux commentedhmm... yes, I meant that, however, now I just figured it is not necessary. For some reason, I was confused. Sorry. :(
Well, I need to test this under IE8, which I do not have at hand, until next Thursday.
This issue confuses me a little because the line in conflict should only be executed for IE6.
Note that this is only executed when
$.browser.version
is 6 or lower.I think I'll have to debug this on a system with IE8, to understand why
$.browser.version
is 6 or lower in IE8. :-/Comment #4
markus_petrux CreditAttribution: markus_petrux commentedJust looking at the code, it seems there's in fact a bug. So, could you please apply this change to parent.js ?
The error seems to be that 'self' was not defined.
Another issue is find out why $.browser.version is 6 or lower in IE8 and fix that as well.
Comment #5
tomsm CreditAttribution: tomsm commentedok, applied the change...and solved! Thanks!
Comment #6
markus_petrux CreditAttribution: markus_petrux commentedThanks for the feadback. I'll commit this in a minute.
In regards to IE6 detection... here's a couple of links for reference:
http://blogs.msdn.com/ie/archive/2009/01/09/the-internet-explorer-8-user...
http://blogs.msdn.com/giorgio/archive/2009/04/14/how-to-detect-ie8-using...
In the end, I think I'll leave the detection code as-is, mostly because once the 'self' is defined, it works. The issue with browser detection in IE8 seems to be that it switches the user agent string based on compatibility mode, and that may fool this kind of conditional execution. However, since it seems to work, it looks like leaving it as-is could be ok.
Comment #7
markus_petrux CreditAttribution: markus_petrux commentedBetter title, and patch committed to CVS:
http://drupal.org/cvs?commit=309776
Comment #9
shijobaby CreditAttribution: shijobaby commentedhttp://ie8troubleshoot.blogspot.com/2010/07/object-doesnt-support-this-p...
Comment #10
HongPong CreditAttribution: HongPong as a volunteer and at kor group commentedI got rid of a similar error with a polyfill. it worked fine right in my theme (affecting IE11)
see https://stackoverflow.com/questions/31119300/ie11-object-doesnt-support-...