When run in installations with lots of queues, it might be interesting to not resetting expired items, especially if looping continuously on short 'time' argument runs.
This option lets you skip the resetting and keeps current behaviour if not specified.
Also adds a '!updated expired items reset.' message to provide feedback.

Patch sent from my own account as opposed to yesterday's one #2560587: Print item details at 'mob-exe-queue' Drush command run (from my work account) to allow proper commit attribution.

EDIT: Also requested additional info on how to implement a 'do not reset items for queue X' feature. A 'mob_queue_reset_items' boolean variable, defaulting to TRUE as current behaviour, but always overridden by '--no-reset-expired' option. To skip resetting a specific queue items would work only when set to FALSE, whatever the '--no-reset-expired' value was. Useful for heavy/long worker function queues or when lots of items are failing, since queue processing could get stuck always processing failed items (happening to me now). Can be a hidden option initially to avoid cluttering the UI, which would need a table or similar.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amontero created an issue. See original summary.

amontero’s picture

Status: Active » Needs review
FileSize
1.73 KB
amontero’s picture

Issue summary: View changes

  • wuinfo committed cc608e4 on 7.x-1.x
    Issue #2561323 by amontero: Add '--no-reset-expired' to allow not to...
wuinfo - Bill Wu’s picture

Status: Needs review » Fixed

Yes, that can be useful in some case. Thanks.

amontero’s picture

Issue summary: View changes

You're welcome, happy to help. Module is being very useful on my setup. Too bad the patch didn't get applied with the --author option ;)

By the comment above of yours, you mean for the accepted patch or for the feature request to have a 'do not reset on a queue by queue basis'? I can open a new issue for it to discuss it and leave it ready to get worked in, if there is enough interest. We have queues for very varying needs and some would definitely need to be reset and others not sometime in the future.

wuinfo - Bill Wu’s picture

Will do that on your next patch. Open another issue for the additional features. Thanks @amontero.

amontero’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.