Task::addComment and Epic::addComment return the result of $comment->save() (which is SAVED_NEW or SAVED_UPDATED) but claim to return the Comment entity in the function comment.

Issue fork minikanban-3529819

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

justanothermark created an issue. See original summary.

justanothermark’s picture

justanothermark commented
Title: Task::addComment() incorrect return type » Task::addComment() and Epic::addComment() incorrect return types
Issue summary: View changes

justanothermark opened merge request !7

justanothermark’s picture

justanothermark commented
Status: Active » Needs review

MR ready for review. As far as I can see, nothing is currently using the return value of addComment so nothing needs updating.

marcus_johansson’s picture

marcus_johansson commented
Status: Needs review » Reviewed & tested by the community

LGTM

andrewbelcher made their first commit to this issue’s fork.

andrewbelcher’s picture

andrewbelcher commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.