Mail System dependency should be optional [#2645680]

Problem/Motivation

The Mail System module is a hard dependency and adds a UI that may allow site admins to change desired functionality

In addition, the REAME for this module describes how a mail key can be set programmatically, so there is no actual need for the Mail System module.

In addition, Mail System apparently writes out PHP class files to the public files directory, which seems a bit dubious in terms of security.

Proposed resolution

Remove Mail System as a requirement, maybe just give a requirement warning if it's absent and mention it in docs.

Remaining tasks

write patch

User interface changes

none

API changes

none

Comment	File	Size	Author
#9	2645680-9-mailsystem_remove.patch	4.49 KB	pounard
#9	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 8 pass PHP 7.2 & MySQL 5.5, D7 8 pass
#5	2645680-5-mailsystem_remove.patch	4.54 KB	pounard
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#3	2645680-3.patch	316 bytes	pwolanin
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 January 2016 at 02:34

pwolanin created an issue. See original summary.

Comment #2

pwolanin CreditAttribution: pwolanin as a volunteer commented 7 January 2016 at 02:39

Issue summary:

View changes

File	Size
2645680-3.patch	316 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Comment #4

pwolanin CreditAttribution: pwolanin as a volunteer commented 7 January 2016 at 02:44

Hmm, expect that will fail since it looks at though a theme setting is used also from mailsystem

Comment #5

pounard

French

CreditAttribution: pounard commented 17 February 2017 at 12:41

File	Size
2645680-5-mailsystem_remove.patch	4.54 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

For two reasons this should be done:

we don't need mailsystem, we use https://github.com/makinacorpus/drupal-netsmtp for both SMTP support
and mail systems dispatch
mailsystem is good for site builders, but we never configure anything via the UI.

The only use Mimemail has for the mailsystem module is UI driven configuration, which is good for site builders, but not required for the rest of the world, and finding the theme for sending mails, hopefully I added the mimemail_theme variable to fallback on in case there's not the mailsystem module enabled.