The check to ignore any content that doesn't have a matching source NID in the node table is a bit naive considering we allow for using a different base node migration and use it for mapping to the real destination NID. In fact, this check isn't really needed at all! Unless we specifically need to handle the use case of missing content that didn't get migrated, I suggest letting these rows fail via the standard migration map destination error and be done with it.

Missing content is usually a bad thing, lets keep it that way.

Comments

techninja’s picture

heddn’s picture

Status: Active » Needs review
StatusFileSize
new6.33 KB

We do need the destination node id (nid) in a couple cases, so we cannot just ignore it. In those cases we can't just let sourceMigration() handle things for us. In those case, we need to remove sourceMigration from the __construct() and call $this->handleSourceMigration($this->arguments['node_migrations'], $row->nid) in prepareRow(). If we do both, then stub webforms with duplicate data get created. Not what we want.

heddn’s picture

Status: Needs review » Fixed

  • heddn committed 8cdbe6b on 7.x-1.x
    Issue #2390317 by techninja, heddn: Rows are ignored if external node...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.