Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We're reusing the SiteSettingsForm (used at installation time to set up the destination Drupal database). In that context, localhost is the most common place to host the Drupal database, so it's collapsed under "Advanced options". Our source database is much more likely to not be localhost, so it should be exposed at the top level - we need to modify the form definition from the parent.
Comment | File | Size | Author |
---|---|---|---|
#1 | localhost_after.png | 90.03 KB | cilefen |
#1 | localhost_before.png | 88.94 KB | cilefen |
#1 | move_hostname_from-2281779-1.patch | 1.09 KB | cilefen |
Comments
Comment #1
cilefen CreditAttribution: cilefen commentedWhat about the field defaults? We may want to unset some of those in another issue. For example, the default for the database name is the Drupal 8 site's database name.
Before:
After:
Comment #3
mikeryanCommitted, thanks!
Yes, please go ahead and open a new issue, I agree the default db name should be cleared - but not the others. It's a common use case to have the source db on the same server as the destination db (and it's my use case as I test;), so it's convenient to have the credentials pre-filled.
One thing to watch out for - test submitting the form with a typo in the credentials, when it reloads we do want the db that the user entered to still be in the form.