Hi, the next notice is appeared on the migrate source page:

Notice: Undefined index: row_index_colums in Drupal\migrate_spreadsheet\Plugin\migrate\source\Spreadsheet->fields() (line 103 of modules/contrib/migrate_spreadsheet/src/Plugin/migrate/source/Spreadsheet.php).

Looks like this check:

if (!empty($row_index_column = $this->getConfiguration()['row_index_colums'])) {

is not correct, because it doesn't check if 'row_index_colums' exists.

I have attached a patch to fix this notice for reviewing.

CommentFileSizeAuthor
#4 migrate_spreadsheet-2857573-misspelled-row_index_column.patch682 bytesdrupalmonkey
#2 1871x617-Selection_03_03_2017_001.png142.5 KBalan-ps
#2 migrate_spreadsheet-undefined_index_row_index_colums.patch825 bytesalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alan-ps created an issue. See original summary.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
FileSize
migrate_spreadsheet-undefined_index_row_index_colums.patch825 bytes
1871x617-Selection_03_03_2017_001.png142.5 KB
codesmith’s picture

codesmith
Location San Francisco
CreditAttribution: codesmith commented

I think that's a different bug. The key should be 'row_index_column' -- not 'row_index_colums'.

drupalmonkey’s picture

drupalmonkey CreditAttribution: drupalmonkey at Digital Bridge Solutions commented
FileSize
migrate_spreadsheet-2857573-misspelled-row_index_column.patch682 bytes

This is the correct patch for this issue. You don't need to check if row_index_column is set here, you just need to spell it right. It will always be set from defaultConfiguration() and setConfiguration().

claudiu.cristea credited claudiu.cristea.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

Thank you for catching this and for the patch.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.