Problem/Motivation

Drupal 9 (seems to be) shipped with symfony/dom-crawler version 4 while this module is requiring version 3, preventing a full upgrade.

Steps to reproduce

Try to upgrade to Drupal 9 with this module installed.

Proposed resolution

Not sure at all that this is the best/correct solution - but it resolves the problem as seems to work correctly.

Remaining tasks

Review if this is the correct solution.

User interface changes

None.

API changes

Should be none.

Data model changes

Should be none.

CommentFileSizeAuthor
#2 migrate_process_inline_images-upgrade_dom_crawler-3194172-0.patch397 bytesasak

Issue fork migrate_process_inline_images-3194172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

asak created an issue. See original summary.

asak’s picture

asak commented
StatusFileSize
new migrate_process_inline_images-upgrade_dom_crawler-3194172-0.patch397 bytes

Patch to resolve attached.

asak opened merge request !1

adamzimmermann’s picture

adamzimmermann commented
Status: Active » Needs review

I'm working with Asaph and we are integrating this with a site that we are updating to D9 in the coming week. We will report back when we have a chance to test a migration once we are on D9.

asak’s picture

asak commented

@adamzimmermann this is required since D9 requires V4 of the above mentioned packages.

callen321’s picture

callen321 commented

This blocks using the module with D9 currently. Any status update?

greg.1.anderson’s picture

greg.1.anderson commented

I have one more D7 site that I want to upgrade to Drupal 9, but I don't know when I'll do that. If anyone would like to co-maintain this project and keep it vibrant please LMK.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community