At the moment, migrate_cron only runs individual migrations without executing their dependencies. If a migration has unmet dependencies, it will be skipped by MigrateExecutable. The below patch provides an additional checkbox to allow Migrate Cron to run dependencies, similar to the option --execute-dependencies from Migrate Tools.

CommentFileSizeAuthor
#11 interdiff-3051619-10-11.txt1.28 KBprudloff
#11 migrate_cron-3051619-11.patch4.18 KBprudloff
#10 3051619-migrate_cron-execute_dependencies-10.patch4.06 KBjohnnydarkko
#6 3051619-migrate_cron-execute_dependencies-6.patch4.07 KBjohnnydarkko
#2 3051619-migrate_cron-execute_dependencies-2.patch4.86 KBsonnykt

Issue fork migrate_cron-3051619

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sonnykt created an issue. See original summary.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
Status: Active » Needs review
StatusFileSize
new 3051619-migrate_cron-execute_dependencies-2.patch4.86 KB
vadimski’s picture

vadimski commented
Assigned: Unassigned » vadimski

drurian made their first commit to this issue’s fork.

drurian opened merge request !1

johnnydarkko’s picture

johnnydarkko commented
StatusFileSize
new 3051619-migrate_cron-execute_dependencies-6.patch4.07 KB

Patch no longer applies in 1.4. Rerolled the patch from #2.

liberatr made their first commit to this issue’s fork.

liberatr’s picture

liberatr
he/him
Primary language English
Location Portland, OR
commented
Version: 8.x-1.2 » 8.x-1.x-dev

Added code from #6 to the Fork repository.

liberatr’s picture

liberatr
he/him
Primary language English
Location Portland, OR
commented
johnnydarkko’s picture

johnnydarkko commented
StatusFileSize
new 3051619-migrate_cron-execute_dependencies-10.patch4.06 KB

Rerolled patch from #6. $migration->get('requirements') is no longer valid
Using $migration->getRequirements(); instead

prudloff’s picture

prudloff commented
StatusFileSize
new migrate_cron-3051619-11.patch4.18 KB
new interdiff-3051619-10-11.txt1.28 KB

The patch in #10 forces the update if track_changes is not defined.
It should also check for high_water_property. We don't want to force the update if this configuration key exists.

NikLP made their first commit to this issue’s fork.

Edit: patch in #11 also applies cleanly to v1.5

somersoft made their first commit to this issue’s fork.

prudloff’s picture

prudloff commented

The MR seems to contain unrelated D11 compatibility changes from #3438494: Automated Drupal 11 compatibility fixes for migrate_cron.

prudloff’s picture

prudloff commented
Status: Needs review » Needs work

phpcs reports some problems.