The iterator in MigrateSourceList::getNextRow() and MigrateSourceMultiItems::getNextRow() has an incorrectly scoped break that causes the iterator to stop after the first pass. This means that returning a NULL from MigrateItem::getItem() as documented to fail a row load results in a NULL row object being passed to Migration::prepareRow(), which effectively kills the migration.

Following patch moves the break to the correct scope in getNextRow() in both classes.

CommentFileSizeAuthor
#1 migrate-fix-break-scope-2488560-01-D7.patch826 bytesarpieb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arpieb’s picture

arpieb CreditAttribution: arpieb commented
FileSize
migrate-fix-break-scope-2488560-01-D7.patch826 bytes
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Priority: Major » Normal
Status: Active » Needs review

When submitting patches be sure to set the status to "Needs review".

  • mikeryan committed da6ecdb on 7.x-2.x authored by arpieb 
    Issue #2488560 by arpieb: MigrateSourceList/MigrateSourceMultiItems...
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Fixed

Committed, thanks!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Issue tags: +Migrate 2.8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.