I noticed that the widget doesn't work with the linkit module.

So I made a patch that extracted some common code to a trait and made a widget class that extends from the linkit widget.

CommentFileSizeAuthor
#10 3158782-10.patch15.15 KBtessa bakker
#10 interdiff-8-10.txt5.49 KBtessa bakker
#8 3158782-8.patch13.57 KBtessa bakker
#8 interdiff-4-8.txt3.36 KBtessa bakker
#7 3158782-6.patch13.39 KBtessa bakker
#7 interdiff-5-6.txt668 bytestessa bakker
#5 interdiff-4-5.txt1.21 KBtessa bakker
#5 3158782-5.patch13.39 KBtessa bakker
#4 3158782-4.patch13.44 KBspadxiii
#3 3158782-3.patch13.4 KBspadxiii
#2 3158782-2.patch6.22 KBspadxiii

Comments

SpadXIII created an issue. See original summary.

spadxiii’s picture

spadxiii commented
Status: Active » Needs review
StatusFileSize
new 3158782-2.patch6.22 KB
spadxiii’s picture

spadxiii commented
StatusFileSize
new 3158782-3.patch13.4 KB

I seem to have forgotten to add the newly created files to the patch.. oops! :)

spadxiii’s picture

spadxiii commented
Version: 8.x-1.x-dev » 2.x-dev
StatusFileSize
new 3158782-4.patch13.44 KB

Added the patch for the 2.x branch.

Note that the patch in #3 is for the 8.x-1.x branch.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Related issues: +#2712951: Linkit for Link field
StatusFileSize
new 3158782-5.patch13.39 KB
new interdiff-4-5.txt1.21 KB

New patch for Linkit Widget support, not the module, but the latest patch in #2712951: Linkit for Link field

The module 'Linkit Widget' no longer works correctly with the current version of Linkit.
A patch is in development to add widget support for link fields to Linkit, this patch is up-2-date with all the latest Linkit features.

As you can see in the interdiff, the Title weight alter has been removed, this is because Linkit has the option to prefill the title, based on the entity label of the selected url (checkbox in form display settings of the widget).

Also the alteration for title weight is not related or needed to make link fields work with Micon and can create unwanted results for other modules.

Status: Needs review » Needs work

The last submitted patch, 5: 3158782-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-5-6.txt668 bytes
new 3158782-6.patch13.39 KB

Fixed summary info for widget.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
StatusFileSize
new interdiff-4-8.txt3.36 KB
new 3158782-8.patch13.57 KB

Patch with code style fixes.

Added complete interdiff of 4 and 8.

Status: Needs review » Needs work

The last submitted patch, 8: 3158782-8.patch, failed testing. View results

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
StatusFileSize
new interdiff-8-10.txt5.49 KB
new 3158782-10.patch15.15 KB

- Fixed Code style issue
- Moved plugin to separate module to set dependency on Linkit

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 3158782-10.patch, failed testing. View results

Status: Needs work » Needs review

The last submitted patch, 4: 3158782-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jacobbell84’s picture

jacobbell84 commented

Looks good, thank you!

jacobbell84’s picture

jacobbell84 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sadly this seems broken with linkit 5 / 6 (Drupal 9): #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3298600: Create a micon + linkit (and micon + linkit + link_attributes) submodule, +#3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6