Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We need a set of standard tests for confirming each meta tag can be output correctly.
Comment | File | Size | Author |
---|---|---|---|
#45 | metatag-n2780025-44.interdiff.txt | 0 bytes | DamienMcKenna |
#45 | metatag-n2780025-44.patch | 51.37 KB | DamienMcKenna |
#10 | metatag-n2780025-10.patch | 24.4 KB | DamienMcKenna |
| |||
#10 | metatag-n2780025-10.interdiff.txt | 4.81 KB | DamienMcKenna |
Comments
Comment #2
DamienMcKennaWIP. Almost there, at least for the base module.
Comment #4
DamienMcKennaFixed the base module's tests.
Comment #6
DamienMcKennaRenamed one of the callbacks, simplified the canonical & shortlink tests.
Comment #8
DamienMcKennaThis fixes up twitter cards and validation tests, and extends the internal API a little.
Comment #10
DamienMcKennaThis fixes the output of Google Plus tags, and fixes tests for Google Plus and Open Graph.
Comment #11
DamienMcKennaWoo! All green! Committed.
Comment #13
DamienMcKennaThis needs to be backported to 7.x-1.x.
Comment #14
DamienMcKennaInitial port to D7 of the functionality for the main module, submodules will come next.
Comment #16
DamienMcKennaA PHP 5.6-ism slipped in by accident.
Comment #18
DamienMcKennaFixed tests for the AppLinks, Dublin Core and Facebook tags.
Comment #20
DamienMcKennaThis adds tests for favicons, and fixes a bug where the core shortcut icon was still being output in certain circumstances.
Comment #22
DamienMcKennaTests for the metatag_google_cse and metatag_google_plus submodules. This also should fix #2832943: Itemprop is empty?.
Comment #24
DamienMcKennaFixed the metatag_hreflang tests.
Comment #26
DamienMcKennaMobile.
Comment #28
DamienMcKennaFixed OG, OG Products and Verification. Last stop - Twitter Cards.
Comment #30
DamienMcKennaAnd Twitter.
Comment #32
DamienMcKennaSo MetatagMobileTagsTest fails on the testbot, but it works locally. OTOH the MetatagCoreXSSTest fails locally X-)
Comment #33
DamienMcKennaI reran the tests locally using PHP 5.3 instead of my usual 5.6, and MetatagMobileTagsTest still works.
Comment #34
DamienMcKennaA minor tweak to confirm that the test page was actually loaded.
Comment #36
DamienMcKennaSimplify the handling of errors when the tag doesn't output properly.
Comment #38
DamienMcKennaThis will fail spectacularly, but it'll help work out what the problem is.
Comment #40
DamienMcKennaSo the root of the problem was that there were test classes with duplicate names. Duh.
Comment #42
DamienMcKennaThis should cover it.
Comment #43
DamienMcKennaThat also fixes the ios-app and android-app alternate tags which were using rel="alternative" instead of rel="alternate". Doh.
Comment #45
DamienMcKennaCommitted! Woot!
Comment #46
DamienMcKennaWe'll do some additional follow-up work in #2834411: Resolve @todo items in tests.