We need a set of standard tests for confirming each meta tag can be output correctly.

CommentFileSizeAuthor
#45 metatag-n2780025-44.interdiff.txt0 bytesDamienMcKenna
#45 metatag-n2780025-44.patch51.37 KBDamienMcKenna
#42 metatag-n2780025-42.patch51.37 KBDamienMcKenna
#42 metatag-n2780025-42.interdiff.txt8.7 KBDamienMcKenna
#40 metatag-n2780025-40.interdiff.txt2.59 KBDamienMcKenna
#40 metatag-n2780025-40.patch45.97 KBDamienMcKenna
#38 metatag-n2780025-38.interdiff.txt1.71 KBDamienMcKenna
#38 metatag-n2780025-38-trashy.patch45.43 KBDamienMcKenna
#36 metatag-n2780025-36.patch45.33 KBDamienMcKenna
#36 metatag-n2780025-36.interdiff.txt2.12 KBDamienMcKenna
#34 metatag-n2780025-34.interdiff.txt1.1 KBDamienMcKenna
#34 metatag-n2780025-34.patch45.23 KBDamienMcKenna
#30 metatag-n2780025-30.patch44.8 KBDamienMcKenna
#30 metatag-n2780025-30.interdiff.txt1.79 KBDamienMcKenna
#28 metatag-n2780025-28.interdiff.txt3.81 KBDamienMcKenna
#28 metatag-n2780025-28.patch43.44 KBDamienMcKenna
#26 metatag-n2780025-26.interdiff.txt5.88 KBDamienMcKenna
#26 metatag-n2780025-26.patch40.03 KBDamienMcKenna
#24 metatag-n2780025-24.interdiff.txt1.41 KBDamienMcKenna
#24 metatag-n2780025-24.patch34.48 KBDamienMcKenna
#22 metatag-n2780025-22.interdiff.txt6.09 KBDamienMcKenna
#22 metatag-n2780025-22.patch33.61 KBDamienMcKenna
#20 metatag-n2780025-20.patch28.37 KBDamienMcKenna
#20 metatag-n2780025-20.interdiff.txt8.82 KBDamienMcKenna
#18 metatag-n2780025-18.interdiff.txt3.97 KBDamienMcKenna
#18 metatag-n2780025-18.patch21.24 KBDamienMcKenna
#16 metatag-n2780025-16.patch18.1 KBDamienMcKenna
#16 metatag-n2780025-16.interdiff.txt579 bytesDamienMcKenna
#14 metatag-n2780025-14.patch18.09 KBDamienMcKenna
#10 metatag-n2780025-10.patch24.4 KBDamienMcKenna
#10 metatag-n2780025-10.interdiff.txt4.81 KBDamienMcKenna
#8 metatag-n2780025-8.patch20.99 KBDamienMcKenna
#8 metatag-n2780025-8.interdiff.txt9.54 KBDamienMcKenna
#6 metatag-n2780025-6.interdiff.txt6.53 KBDamienMcKenna
#6 metatag-n2780025-6.patch15.68 KBDamienMcKenna
#4 metatag-n2780025-3.patch11.96 KBDamienMcKenna
#4 metatag-n2780025-3.interdiff.txt431 bytesDamienMcKenna
#2 metatag-n2780025-2.patch11.96 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
11.96 KB

WIP. Almost there, at least for the base module.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2780025-2.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
431 bytes
11.96 KB

Fixed the base module's tests.

Status: Needs review » Needs work

The last submitted patch, 4: metatag-n2780025-3.patch, failed testing.

DamienMcKenna’s picture

Renamed one of the callbacks, simplified the canonical & shortlink tests.

Status: Needs review » Needs work

The last submitted patch, 6: metatag-n2780025-6.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
9.54 KB
20.99 KB

This fixes up twitter cards and validation tests, and extends the internal API a little.

Status: Needs review » Needs work

The last submitted patch, 8: metatag-n2780025-8.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
4.81 KB
24.4 KB

This fixes the output of Google Plus tags, and fixes tests for Google Plus and Open Graph.

DamienMcKenna’s picture

Status: Needs review » Fixed
Parent issue: » #2741339: Plan for Metatag 8.x-1.0-beta10 release

Woo! All green! Committed.

  • DamienMcKenna committed ef090b3 on 8.x-1.x
    Issue #2780025 by DamienMcKenna: Basic tests for the output of every...
DamienMcKenna’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

This needs to be backported to 7.x-1.x.

DamienMcKenna’s picture

Status: Patch (to be ported) » Needs review
FileSize
18.09 KB

Initial port to D7 of the functionality for the main module, submodules will come next.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n2780025-14.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
579 bytes
18.1 KB

A PHP 5.6-ism slipped in by accident.

Status: Needs review » Needs work

The last submitted patch, 16: metatag-n2780025-16.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
21.24 KB
3.97 KB

Fixed tests for the AppLinks, Dublin Core and Facebook tags.

Status: Needs review » Needs work

The last submitted patch, 18: metatag-n2780025-18.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
8.82 KB
28.37 KB

This adds tests for favicons, and fixes a bug where the core shortcut icon was still being output in certain circumstances.

Status: Needs review » Needs work

The last submitted patch, 20: metatag-n2780025-20.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
33.61 KB
6.09 KB

Tests for the metatag_google_cse and metatag_google_plus submodules. This also should fix #2832943: Itemprop is empty?.

Status: Needs review » Needs work

The last submitted patch, 22: metatag-n2780025-22.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
34.48 KB
1.41 KB

Fixed the metatag_hreflang tests.

Status: Needs review » Needs work

The last submitted patch, 24: metatag-n2780025-24.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
40.03 KB
5.88 KB

Mobile.

Status: Needs review » Needs work

The last submitted patch, 26: metatag-n2780025-26.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
43.44 KB
3.81 KB

Fixed OG, OG Products and Verification. Last stop - Twitter Cards.

Status: Needs review » Needs work

The last submitted patch, 28: metatag-n2780025-28.patch, failed testing.

DamienMcKenna’s picture

Status: Needs review » Needs work

The last submitted patch, 30: metatag-n2780025-30.patch, failed testing.

DamienMcKenna’s picture

So MetatagMobileTagsTest fails on the testbot, but it works locally. OTOH the MetatagCoreXSSTest fails locally X-)

DamienMcKenna’s picture

I reran the tests locally using PHP 5.3 instead of my usual 5.6, and MetatagMobileTagsTest still works.

DamienMcKenna’s picture

A minor tweak to confirm that the test page was actually loaded.

Status: Needs review » Needs work

The last submitted patch, 34: metatag-n2780025-34.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
2.12 KB
45.33 KB

Simplify the handling of errors when the tag doesn't output properly.

Status: Needs review » Needs work

The last submitted patch, 36: metatag-n2780025-36.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
45.43 KB
1.71 KB

This will fail spectacularly, but it'll help work out what the problem is.

Status: Needs review » Needs work

The last submitted patch, 38: metatag-n2780025-38-trashy.patch, failed testing.

DamienMcKenna’s picture

So the root of the problem was that there were test classes with duplicate names. Duh.

Status: Needs review » Needs work

The last submitted patch, 40: metatag-n2780025-40.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
8.7 KB
51.37 KB

This should cover it.

DamienMcKenna’s picture

That also fixes the ios-app and android-app alternate tags which were using rel="alternative" instead of rel="alternate". Doh.

  • DamienMcKenna committed 384ad56 on 7.x-1.x
    Issue #2780025 by DamienMcKenna: Backported output tests from D8. Also...
DamienMcKenna’s picture

Status: Needs review » Fixed
FileSize
51.37 KB
0 bytes

Committed! Woot!

DamienMcKenna’s picture

We'll do some additional follow-up work in #2834411: Resolve @todo items in tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.