The mask icon's "rel" tag value is reversed, it should be "mask-icon" but it comes out as "icon-mask".

CommentFileSizeAuthor
#10 metatag-n2752319-10.interdiff.txt1.13 KBDamienMcKenna
#10 metatag-n2752319-10.patch39.34 KBDamienMcKenna
#8 metatag-n2752319-8b.interdiff.txt7.56 KBDamienMcKenna
#8 metatag-2752319-8.patch39.06 KBDamienMcKenna
#6 metatag-n2752319-6.patch29.18 KBDamienMcKenna
#2 metatag-n2752319-2.patch658 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
metatag-n2752319-2.patch658 bytes

The '#rel' value was set incorrectly, so it doesn't require any update scripts to clear any caches.

  • DamienMcKenna committed 4161d04 on 7.x-1.x 
    Issue #2752319 by DamienMcKenna: Fixed output of the mask-icon meta tag.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2742169: Plan for Metatag 7.x-1.17 release

Committed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Fixed » Needs review
FileSize
metatag-n2752319-6.patch29.18 KB

This adds a test to confirm the meta tag is output correctly, and includes a copy of the druplicon SVG file from the media kit used for the tests. It also makes the mask-icon an "image" so different URL formats will be handled correctly and it'll also always out an absolute URL.

Status: Needs review » Needs work

The last submitted patch, 6: metatag-n2752319-6.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: The mask-icon meta tag is backwards » The mask-icon meta tag is backwards, add 'color' attribute
Status: Needs work » Needs review
FileSize
metatag-2752319-8.patch39.06 KB
metatag-n2752319-8b.interdiff.txt7.56 KB

This has a few changes:

  • There's a new 'url' attribution for meta tag definitions that will ensure the strings are absolute URLs.
  • There's a new class to handle the new "color" attribute of the "mask-icon" meta tag.
  • Moar tests! :)

Status: Needs review » Needs work

The last submitted patch, 8: metatag-2752319-8.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2752319-10.patch39.34 KB
metatag-n2752319-10.interdiff.txt1.13 KB

This will hopefully fix the tests.

  • DamienMcKenna committed d6de7a3 on 7.x-1.x 
    Issue #2752319 by DamienMcKenna: Added the mask-icon 'color' attribute,...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Awesome!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jason_purdy’s picture

jason_purdy CreditAttribution: jason_purdy commented

Has the color attribute been added to the D8 branch?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

No, but I added an issue so we don't forget it needs to be added: #2914998: Add the mask icon "color" attribute