Issue Summary
Rather than creating a huge spreadsheet, it might be useful if there was a way of controlling all default configs at once on a huge grid page.
Job Stories
- When I am maintaining metatag default configurations, I need to be able to quickly get an overview of all the defaults on my site so I can easily update them.
- When I am setting up metatag default configurations, I need to be able to quickly enter a number of default configurations so I can work more efficiently.
- When I have to adjust metatag default configurations, I need to be able to quickly see all the defaults currently in the system so I can evaluate which tags to update and which to add.
Proposed Solution
Comment | File | Size | Author |
---|---|---|---|
#33 | metatag-n2664038-33.interdiff.txt | 4.77 KB | DamienMcKenna |
#33 | metatag-n2664038-33.patch | 21.07 KB | DamienMcKenna |
|
Comments
Comment #2
DamienMcKennaWIP.
Comment #3
DamienMcKennaGoing to see if I can have some help with the UX around this.
Comment #4
DamienMcKennaTodo:
Comment #5
Dave ReidI'd love to know what problem this is wanting to solve. Is this for editing a config itself? Or all the configs?
Comment #6
DamienMcKennaThe idea is to replace the giant spreadsheet I came up with for planning the defaults, having it all on one page makes it easier to see them all at a glance.
Comment #7
DamienMcKennaComment #8
DamienMcKennaThis changes the form to use the metatag's form method, moves the tag's description into the field's 'title' attribute, and adds a column to indicate the config's state.
Comment #9
DamienMcKennaThis adds a save button and fixes the token handling so the form doesn't throw token validation errors. Note: it doesn't actually save yet ;-)
Comment #10
DamienMcKennaThe save operation now works! :-)
Comment #11
DamienMcKennaThis adds an option to enable or disable the configuration, and a way of adding new entity/bundle configs.
Comment #12
DamienMcKennaThis removes the '#states' logic because the form was getting a bit messy.
Comment #13
yoroy CreditAttribution: yoroy at Roy Scholten commentedBefore/after screenshots would make it easier to understand what the proposed change is and review it :)
Comment #14
DamienMcKennaRight now it adds a separate page that looks like this:
All of the meta tags scroll out to the right, with each configuration a separate row.
At the bottom of the page is the following:
Comment #15
DamienMcKennaAnyone have any thoughts on what the page should be called? "Grid" seems a little too unhelpful.
Comment #16
Dave ReidI'm feeling like this is a more advanced UI that shouldn't be included by default. This has the easy possibility of overwhelming users getting started.
Comment #17
Dave Reid(by that I mean a sub-module not enabled by default)
Comment #18
DamienMcKenna@Dave Reid: That's entirely reasonable. I also anticipate possible problems with the form submission when several submodules are enabled and with lots of entity types because of the number of fields that would be submitted.
Comment #19
DamienMcKenna@Dave Reid: What do you think of "metatag_alt_ui", or "metatag_advanced_ui"?
Comment #20
danigrrl CreditAttribution: danigrrl as a volunteer commentedI'm trying to understand the job someone is trying to do here. Is it to manage all their tags? Add new tags?
Comment #21
danigrrl CreditAttribution: danigrrl as a volunteer commentedUpdated issue summary. Please advise if I've summarized the jobs to be done effectively.
Comment #22
DamienMcKennaHey there :) I've tweaked the stories a little to focus on the default configurations.
Comment #23
DamienMcKennaComment #24
DamienMcKenna@danigrrl: Thanks for your help. I'll get back to this soon.
Comment #25
DamienMcKennaMaybe it could be a submodule that just replaces the existing config page? So you'd turn on the module and the existing "Defaults" page would be replaced by the grid. Hrm..
Comment #26
DamienMcKennaOne thing this would have to watch for is the max_input_vars variable, maybe there should be a hook_requirements() check to see if it would even be feasible to save the form based upon what it's set to.
Comment #27
DamienMcKennaA submodule.
Comment #28
DamienMcKennaNeeds tests.
Comment #29
DamienMcKennaFixed form saving, added some messages to hook_requirements, and added tests to ensure that toggling a config's status will work.
Comment #30
DamienMcKennaThis reworked the structure so that there are separate columns for each tag group, rather than each tag being in a separate column.
Comment #31
DamienMcKennaThis adds all for each config that were present on the non-grid display, but I've had to disable the tests as they need to be redone.
Comment #32
DamienMcKennaI think the better approach would be to show all tags horizontally and then have a search (like the Module Filter module) to limit the display.
Comment #33
DamienMcKennaThis goes back to having one column for each tag.
Comment #34
DamienMcKenna