Issue Summary

Rather than creating a huge spreadsheet, it might be useful if there was a way of controlling all default configs at once on a huge grid page.

Job Stories

  • When I am maintaining metatag default configurations, I need to be able to quickly get an overview of all the defaults on my site so I can easily update them.
  • When I am setting up metatag default configurations, I need to be able to quickly enter a number of default configurations so I can work more efficiently.
  • When I have to adjust metatag default configurations, I need to be able to quickly see all the defaults currently in the system so I can evaluate which tags to update and which to add.

Proposed Solution

Metatag default screen
Metatag default screen bottom

CommentFileSizeAuthor
#33 metatag-n2664038-33.interdiff.txt4.77 KBDamienMcKenna
#33 metatag-n2664038-33.patch21.07 KBDamienMcKenna
#31 metatag-n2664038-31.patch21.9 KBDamienMcKenna
#31 metatag-n2664038-31.interdiff.txt7.09 KBDamienMcKenna
#30 metatag-n2664038-30.interdiff.txt4.42 KBDamienMcKenna
#30 metatag-n2664038-30.patch18.74 KBDamienMcKenna
#29 metatag-n2664038-29.interdiff.txt8.46 KBDamienMcKenna
#29 metatag-n2664038-29.patch17.91 KBDamienMcKenna
#27 metatag-n2664038-27.patch13.84 KBDamienMcKenna
#14 metatag-n2664038-14b.png36.62 KBDamienMcKenna
#14 metatag-2664038-14.png77.78 KBDamienMcKenna
#12 metatag-n2664038-12.patch9.47 KBDamienMcKenna
#12 metatag-n2664038-12.interdiff.txt1.23 KBDamienMcKenna
#11 metatag-n2664038-11.patch9.3 KBDamienMcKenna
#11 metatag-n2664038-11.interdiff.txt4.8 KBDamienMcKenna
#10 metatag-n2664038-10.interdiff.txt2.08 KBDamienMcKenna
#10 metatag-n2664038-10.patch7.39 KBDamienMcKenna
#9 metatag-n2664038-9.patch5.89 KBDamienMcKenna
#9 metatag-n2664038-9.interdiff.txt2.81 KBDamienMcKenna
#8 metatag-n2664038-8.patch4.79 KBDamienMcKenna
#2 metatag-n2664038-2.patch3.59 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
3.59 KB

WIP.

DamienMcKenna’s picture

Issue tags: +Needs usability review

Going to see if I can have some help with the UX around this.

DamienMcKenna’s picture

Status: Needs review » Needs work

Todo:

Dave Reid’s picture

I'd love to know what problem this is wanting to solve. Is this for editing a config itself? Or all the configs?

DamienMcKenna’s picture

The idea is to replace the giant spreadsheet I came up with for planning the defaults, having it all on one page makes it easier to see them all at a glance.

DamienMcKenna’s picture

Issue tags: +Usability
DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
4.79 KB

This changes the form to use the metatag's form method, moves the tag's description into the field's 'title' attribute, and adds a column to indicate the config's state.

DamienMcKenna’s picture

This adds a save button and fixes the token handling so the form doesn't throw token validation errors. Note: it doesn't actually save yet ;-)

DamienMcKenna’s picture

DamienMcKenna’s picture

This adds an option to enable or disable the configuration, and a way of adding new entity/bundle configs.

DamienMcKenna’s picture

This removes the '#states' logic because the form was getting a bit messy.

yoroy’s picture

Before/after screenshots would make it easier to understand what the proposed change is and review it :)

DamienMcKenna’s picture

Right now it adds a separate page that looks like this:
Grid page

All of the meta tags scroll out to the right, with each configuration a separate row.

At the bottom of the page is the following:
Grid page save options

DamienMcKenna’s picture

Anyone have any thoughts on what the page should be called? "Grid" seems a little too unhelpful.

Dave Reid’s picture

I'm feeling like this is a more advanced UI that shouldn't be included by default. This has the easy possibility of overwhelming users getting started.

Dave Reid’s picture

(by that I mean a sub-module not enabled by default)

DamienMcKenna’s picture

@Dave Reid: That's entirely reasonable. I also anticipate possible problems with the form submission when several submodules are enabled and with lots of entity types because of the number of fields that would be submitted.

DamienMcKenna’s picture

@Dave Reid: What do you think of "metatag_alt_ui", or "metatag_advanced_ui"?

danigrrl’s picture

I'm trying to understand the job someone is trying to do here. Is it to manage all their tags? Add new tags?

danigrrl’s picture

Issue summary: View changes

Updated issue summary. Please advise if I've summarized the jobs to be done effectively.

DamienMcKenna’s picture

Issue summary: View changes

Hey there :) I've tweaked the stories a little to focus on the default configurations.

DamienMcKenna’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests
DamienMcKenna’s picture

@danigrrl: Thanks for your help. I'll get back to this soon.

DamienMcKenna’s picture

Maybe it could be a submodule that just replaces the existing config page? So you'd turn on the module and the existing "Defaults" page would be replaced by the grid. Hrm..

DamienMcKenna’s picture

One thing this would have to watch for is the max_input_vars variable, maybe there should be a hook_requirements() check to see if it would even be feasible to save the form based upon what it's set to.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
13.84 KB

A submodule.

DamienMcKenna’s picture

Status: Needs review » Needs work

Needs tests.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
17.91 KB
8.46 KB

Fixed form saving, added some messages to hook_requirements, and added tests to ensure that toggling a config's status will work.

DamienMcKenna’s picture

This reworked the structure so that there are separate columns for each tag group, rather than each tag being in a separate column.

DamienMcKenna’s picture

This adds all for each config that were present on the non-grid display, but I've had to disable the tests as they need to be redone.

DamienMcKenna’s picture

I think the better approach would be to show all tags horizontally and then have a search (like the Module Filter module) to limit the display.

DamienMcKenna’s picture

This goes back to having one column for each tag.

DamienMcKenna’s picture

Status: Needs review » Needs work