I added functionality to transfer the settings of module metatag with features. If you decide to add the patch, please specify me as author of a commit.

Thank you for your module.

CommentFileSizeAuthor
#20 metatag-n1818300-19.patch2.96 KBDamienMcKenna
#17 metatag-n1818300-17.patch2.96 KBDamienMcKenna
#13 metatag-n1818300-13.patch2.9 KBDamienMcKenna
#12 metatag-n1818300-12.patch0 bytesDamienMcKenna
#10 metatag-export-config-through-features-1818300.patch2.6 KBeugene.ilyin
#6 metatag-export-config-through-features-1818300.patch2.76 KBeugene.ilyin
#3 metatag-export-config-through-features-1818300.patch2.94 KBeugene.ilyin
#1 metatag-export-config-through-features-1818300.patch2.93 KBeugene.ilyin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
FileSize
metatag-export-config-through-features-1818300.patch2.93 KB

Patch

Status: Needs review » Needs work

The last submitted patch, metatag-export-config-through-features-1818300.patch, failed testing.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
FileSize
metatag-export-config-through-features-1818300.patch2.94 KB

hm validation error... try again. This patch should works good.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, metatag-export-config-through-features-1818300.patch, failed testing.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs work » Needs review
FileSize
metatag-export-config-through-features-1818300.patch2.76 KB

It seems that the problem was related to the addition of a new file in the patch. Strange that it did not work. This patch should work fine. I checked that it is correctly applied in my IDE (Netbeans).

The last submitted patch, metatag-export-config-through-features-1818300.patch, failed testing.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs review » Needs work

I do not know why the patch is not applied. In my IDE (NetBeans) it is correctly applied to module version 7.x-alpha-8. What do I do?

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs work » Needs review
FileSize
metatag-export-config-through-features-1818300.patch2.6 KB

Maybe problem in paths...

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Phew, that was more difficult than writing the code for the patch :)
Please do not forget to mention me as the author of a commit.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-1.0-alpha8 » 7.x-1.x-dev
FileSize
metatag-n1818300-12.patch0 bytes

It should work if the hooks are separated into another file.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
metatag-n1818300-13.patch2.9 KB

This will work better than the file in #12 X-) So apparently in hook_features_api you have to use drupal_get_path('module', 'metatag') rather than using dirname(__FILE__) in order for the hooks to properly work. I also renamed some of the values to 'metatag' instead of 'metatags' as the module's name is specifically "metatag".

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Needs work

My initial testing:

  • The export appears to work correctly.
  • I have not tried importing the configuration into another site yet.
  • Needed: it needs to add a dependencies line in the info file for the Metatag module.
eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs work » Needs review

Which dependencies you mean?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Needs work

Metatag should be listed as a dependency, i.e.:

dependencies[] = metatag
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
FileSize
metatag-n1818300-17.patch2.96 KB

This adds the dependencies[] line.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Are you sure that this must be do in a foreach? I think what better if we add this dependencies key just once.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs review » Needs work
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
FileSize
metatag-n1818300-19.patch2.96 KB

Valid point.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Now this patch is ready to be added into module?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

I need to test how well the settings are imported :) I'll try it later today.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

ok, thx. Make patches is important for my work :)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

I tested it out and it appeared to work really well with a snapshot of Features from late August - good work, thanks! This has been committed!

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

thank you! :)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Fixed » Closed (fixed)

This has been released in 1.0-beta2: http://drupal.org/node/1826908

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Issue summary: View changes

edit text