Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
is there a way to delegate meta tags appliance conditions to the proper Context module and then concentrate on the meta tags reaction?
Context is a great module which phylosophy is very user friendly, and having all reactions in one place allows to save time.
Comment | File | Size | Author |
---|---|---|---|
#23 | metatag-n1187710-23.patch | 923 bytes | DamienMcKenna |
Comments
Comment #1
Dave ReidI'm not too familiar with the context module so it may take someone else to write this code. Leaving as postponed for now.
Comment #2
dropbydrop CreditAttribution: dropbydrop commentedsub
Comment #3
Dave ReidI did not use the correct postponed.
Comment #4
DamienMcKennaTwo related modules:
I think this should be done as a submodule so it can leverage & standardize on the main module's meta tagging, e.g. #1160340: Rewrite as a submodule of Metatags (D7 branch), possibly inviting other authors to join as co-maintainers for their pieces. Thoughts?
Comment #5
DamienMcKennaUpdated title.
Comment #6
dakku CreditAttribution: dakku commentedHI Damien,
You have mail :D
Comment #7
tahiticlic CreditAttribution: tahiticlic commentedNice Damien!
Comment #8
dropbydrop CreditAttribution: dropbydrop commentedSo since there is new module, is this issue fixed?
Comment #9
DamienMcKenna@dropbydrop: I'd like Metatag have the ability to do this out of the box.
Comment #10
DamienMcKennaDigging into it I think this needs to be a submodule, but I also think it should be the official mechanism for assigning meta tags to content by path rather than by entity.
Comment #11
DamienMcKennaDrawing a blank. I need to talk with Dave about how to combine the context-driven meta tags with the ones generated by the system. Argh.
Comment #12
DamienMcKennaFYI I've uploaded some WIP code to the 'context' branch.
Comment #13
Miszel CreditAttribution: Miszel commentedMy integration code can be checked out from here: http://drupal.org/sandbox/marcin_pajdzik/1810914
Comment #14
DamienMcKennaMarcin Pajdzik++
:)
Comment #15
DamienMcKennaI've tested out the new sandbox and, well, it's *great*! *Really* good work, Marcin!
Comment #16
blairski CreditAttribution: blairski commentedI did a test run and it works well. Good job .
Just one thing: change the module name to
. Currently the git clone creates
Comment #17
Miszel CreditAttribution: Miszel commentedThanks for the reviews guys. I have slightly changed the way the metatag "per path" admin page works as the previous solution was unreliable:
#1814074: Improve the level of control over what is being displayed on the metatag per path admin page.
Comment #18
DamienMcKennaI've merged in Marcin's sandbox into the new 1187710-context branch. I've made a few small changes, inc renaming the admin page's path, but the kudos go to Marcin.
Comment #19
DamienMcKennaInstructions for checking out the new branch: http://drupal.org/node/640498/git-instructions/1187710-context/nonmainta...
Comment #20
DamienMcKennaI've made a number of improvements to the Context submodule:
This appears to be working fine.
Comment #21
Miszel CreditAttribution: Miszel commentedOne more fix. Please change:
to:
in metatag_context.admin.inc line 11
Comment #22
DamienMcKennaCommitted! Thanks everyone for your help with this, especially Marcin!
Comment #23
DamienMcKennaA little follow-up to update the main module's README.txt file.
Comment #24
DamienMcKennaI've committed the patch from #23 too.
Comment #25
DamienMcKennaLast night saw the release of 7.x-1.0-beta1, so I'm closing all these "fixed" issues in the interest of tidying up the issue queue. Thank you all for your help getting us to this point!
Comment #26
remkovdz CreditAttribution: remkovdz commentedThis works great, thanks a lot!
Comment #27
MXTOnly to inform you guys: I've installed latest DEV version of context (2012-Oct-10) and no metatada reaction is available in context UI.
Downgrading to context 7.x-3.0-beta4 meradata reaction return available.
Comment #28
DamienMcKenna@MXT: Please open a new issue for this. Thanks.
Comment #29
mstrelan CreditAttribution: mstrelan commented@MXT - see #1871798: Context reaction is not available after module installation until the cache is cleared. This might result in an additional issue for metatag.