CommentFileSizeAuthor
#19 2854800-19.patch865 bytesRamya Balasubramanian
#15 no-configure-link-in-module-listing-2854800-14.patch864 bytesRamya Balasubramanian
#14 missing-description-3092928-1.patch470 bytesRamya Balasubramanian
#13 no-configure-link-2854800-13.patch862 bytesRamya Balasubramanian
#10 After.png73.96 KBzalak.addweb
#10 Before.png64.74 KBzalak.addweb
#9 no_configure_link_in-2854800-9.patch326 bytesdhruveshdtripathi
#6 no_configure_link_in-2854800-6.patch328 bytesdhruveshdtripathi
#3 messagesubscribe.png23.4 KBPavan B S
no_configure_link_in_module_page.patch332 bytesZnak

Issue fork message_subscribe-2854800

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Znak created an issue. See original summary.

Znak’s picture

Znak CreditAttribution: Znak commented
Assigned: Znak » Unassigned
Priority: Normal » Major
Status: Active » Needs review
Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
FileSize
messagesubscribe.png23.4 KB

@Znak configure link is showing to me before applying the patch.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Status: Needs review » Needs work

@pavan-b-s Link is there but isn't working.

@Znak You've made a mistake in the patch.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
no_configure_link_in-2854800-6.patch328 bytes
zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented
Status: Needs review » Needs work

@dhruveshdtripathi,I've checked your patch with Simplytest.Me but still it didn't show me Configure link after enabling the module.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
no_configure_link_in-2854800-9.patch326 bytes

My bad! The patch by @Znak was correct. Got confused in the admin settings form code. Reverting back to @Znak's patch.

zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented
Status: Needs review » Reviewed & tested by the community
FileSize
Before.png64.74 KB
After.png73.96 KB

@znak, Thanks for the link it works well PFA.

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Issue tags: +Needs backport to D7
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
no-configure-link-2854800-13.patch862 bytes

Hi @jhedstrom,

Here I have attached the patch. In this patch configure link will also work. Please have a look and let me know if there is any issues.

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company commented
FileSize
missing-description-3092928-1.patch470 bytes

Hi @jhedstrom,
Please ignore this patch, as I have updated the wrong patch file

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company commented
FileSize
no-configure-link-in-module-listing-2854800-14.patch864 bytes

Sorry guys, Please ignore the last patch. Please have a look at this patch.

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented

@raunak singh,
Please test this patch.

rishab.singh’s picture

rishab.singh CreditAttribution: rishab.singh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

Review and Testing this patch

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Priority: Major » Minor
Status: Reviewed & tested by the community » Needs work 
+++ b/message_subscribe.routing.yml
@@ -2,6 +2,6 @@ message_subscribe.admin_settings:
-    _form: \Drupal\message_subscribe\Form\MessageSubscribeAdminSettings

I think the backslash is needed here.

Ramya Balasubramanian’s picture

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2854800-19.patch865 bytes

Hi @jhedstrom,
I have addressed #18 comment.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at OpenPlus commented

The patch in #19 looks good, though I do not think the changes to message_subscribe.routing.yml are needed.

bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Assigned: Unassigned » bluegeek9
Category: Bug report » Task
Status: Needs review » Active
Issue tags: -Needs backport to D7

bluegeek9 opened merge request !11

bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review

  • bluegeek9 committed 9eb11268 on 8.x-1.x 
    Issue #2854800 by Ramya Balasubramanian, dhruveshdtripathi, Znak, zalak....
bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Status: Needs review » Fixed
jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Related issues: +#2603640: Add configure link

Here is the Drupal 7 version of this issue.

#2603640: Add configure link

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.