Problem/Motivation

MercuryEditorEntityFormTrait::save() checks that the saved entity implements RevisionableInterface which works in most cases. In trying to get ME to support the Config Pages module, I ran into an issue. The ConfigPages entity implements ContentEntityBase which in turn implements ContentEntityInterface which after a couple layers implements RevisionableInterface. This despite the fact Config Pages are not setup to be revisionable (see #3133942: Make config pages revisionable ). So when the ::save() method tries to load the latest revision the script fails. Checking that we get a revision ID before loading it makes that a little safer.

Issue fork mercury_editor-3463615

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jnettik created an issue. See original summary.

jnettik opened merge request !57

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
commented
Status: Active » Needs review

MR ready for review.

justin2pin made their first commit to this issue’s fork.

  • justin2pin committed c794c71a on 2.1.x authored by jnettik 
    Issue #3463615 by jnettik: White screen when revision ID is empty
justin2pin’s picture

justin2pin commented
Status: Needs review » Fixed

  • justin2pin committed c794c71a on decoupled authored by jnettik 
    Issue #3463615 by jnettik: White screen when revision ID is empty

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.