In order to support inline editing of text and other fields directly in the live preview, we need to make some light modifications to the UI - basically ensuring UI controls don't significantly overlap content or interfere with user interactions.
Additionally, inline editing should be fixed / extended to work with CKEditor5 out of the box, with eventual support for plaintext and other field types.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | nested-reveal-on-hover.png | 436.16 KB | khaldoon_masud |
| #12 | mercury-contextual-links.png | 21.98 KB | khaldoon_masud |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
justin2pin commentedComment #6
alisonHi! If I wanted to test this, should I try MR 46, or, which MR? Thanks!
Comment #7
alison(sorry for the extra comment) And, is issue #3362776 a requirement / prerequisite for the fix(es) on this issue (#3426739)?
#3362776: Inline text editor not working
Comment #9
justin2pin commentedSupport for inline editing is being deprecated from Mercury Editor and is moving to a separate module -- stay tuned for more information on that release. MR46 adds interface refinements that minimize component controls so that inline editing is more accessible once turned on. Marking as fixed, will update this issue once the new contrib module is available.
Comment #10
justin2pin commentedComment #12
khaldoon_masud commentedThe change in this is creating nested contextual links and hiding up,down, edit, duplicate and delete buttons.
see https://www.drupal.org/files/issues/2024-12-12/mercury-contextual-links.png
line 132 in web/modules/contrib/mercury_editor/mercury_editor.module
$variables['controls']['label']['#suffix'] = '';
$variables['controls']['delete_link']['#suffix'] = '';
Removing above lines fixes the issue.
You can see the HTML structure in https://www.drupal.org/files/issues/2024-12-12/nested-reveal-on-hover.png