The function menuperformance_module_implements_alter puts the form_altering done by menuperformance last. The PHP doc states
* Makes sure that menuperformance alters the vocabulary form after the
* taxonomy_menu module.
I suppose the hook has been implemented because of #2053517: Notices when taxonomy menu is activated and a new vocabulary is made. But as the title says this prevents the menu_attributes module to do its thing. This means there are no fields from that module being added to the node form.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | menuperformance-fix_form_alter_hook_order-2828611-2.patch | 1.34 KB | Sneakyvv |
Comments
Comment #2
Sneakyvv commentedFirst, it should only really be done when taxonomy_menu is available and enabled.
Second, menuperformance's altering should be done after taxonomy_menu's (as per PHP doc), so it would be better to put taxonomy_menu's hook just before menuperformance's instead of putting menuperformance last.
Last, why is there a check if menuperformance is in the $implementation array? I kept the if check but removed the else which used to add it anyway, but with a empty string. But, perhaps the if should be removed altogether.
Comment #3
Sneakyvv commentedAlso applies to latest dev.