Menu item extras doesn't uninstall cleanly

Probably related core issue: https://www.drupal.org/project/drupal/issues/3052318

@devarch - that's exactly the case with other two reporters (including me): module is not installed or was removed but MenuItemExtrasMenuLinkContent definition is still present in value column of key_value table for the following record:

• collection: entity.definitions.installed
• name: menu_link_content.entity_type

I am having the same issue. Menu Item Extras was installed to evaluate, then removed; database update fails after upgrading to Drupal 8.7.0.

I was able to work around this by doing the following:

1. Downloading the latest dev release of Menu Item Extras
2. Installing and enabling the devel module
3. Reinstalling Menu Item Extras; drush dre menu_item_extras
4. Rebuild cache; drush cr
5. Update database; drush updb
6. Rebuild cache again; drush cr
7. Uninstall Menu Item Extras; drush pm-uninstall menu_item_extras

I hope this can help anyone else dealing with this issue.

Reinstalling on 8.7.0 gives me the following error

In SqlContentEntityStorage.php line 847:
                                                                               
  SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'bundle' canno  
  t be null: UPDATE {menu_link_content} SET bundle=:db_update_placeholder_0,   
  uuid=:db_update_placeholder_1, langcode=:db_update_placeholder_2             
  WHERE id = :db_condition_placeholder_0; Array                                
  (                                                                            
      [:db_update_placeholder_0] =>                                            
      [:db_update_placeholder_1] => e2f10602-6806-4943-9f22-aa2f059b2aed       
      [:db_update_placeholder_2] => en                                         
      [:db_condition_placeholder_0] => 1                                       
  )                                                                            
                                                                               

In Connection.php line 689:
                                                                               
  SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'bundle' canno  
  t be null: UPDATE {menu_link_content} SET bundle=:db_update_placeholder_0,   
  uuid=:db_update_placeholder_1, langcode=:db_update_placeholder_2             
  WHERE id = :db_condition_placeholder_0; Array                                
  (                                                                            
      [:db_update_placeholder_0] =>                                            
      [:db_update_placeholder_1] => e2f10602-6806-4943-9f22-aa2f059b2aed       
      [:db_update_placeholder_2] => en                                         
      [:db_condition_placeholder_0] => 1                                       
  )                                                                            
                                                                               

In Statement.php line 59:
                                                                               
  SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'bundle' cannot be null 

Re-installing the module suppresses the error about the missing Class but doesn't fix the problems with upgrading.

Based on the original post information I was able to manual edit the row in key_value [collection=entity.definitions.installed
and name=menu_link_content.entity_type] as follows:

s:8:" * class";s:60:"Drupal\menu_item_extras\Entity\MenuItemExtrasMenuLinkContent";
s:8:" * class";s:47:"Drupal\menu_link_content\Entity\MenuLinkContent";

Then I was able to run the database updates without error. Not sure how this needs to be fixed in future versions so the module uninstalls clean, but hopefully this will help some folks stuck in a similar spot.

Update, I wrote an update hook for use in a custom module to do the basic replace:

/**
 * Fix for uninstalled Menu Item Extras Class that was left behind.
 */
function mymodule_update_8100() {

  // Load the menu_link_content.entity_type value and modify class.
  $connection = \Drupal::database();
  $query = $connection->select('key_value', 'k');
  $query->condition('k.collection', 'entity.definitions.installed');
  $query->condition('k.name', 'menu_link_content.entity_type');
  $query->fields('k', ['value']);
  $result = $query->execute();

  foreach ($result as $record) {
    $value = unserialize($record->value);
    $value->setClass('Drupal\menu_link_content\Entity\MenuLinkContent');
    $query = \Drupal::database()->update('key_value');
    $query->fields(['value' => serialize($value)]);
    $query->condition('collection', 'entity.definitions.installed');
    $query->condition('name', 'menu_link_content.entity_type');
    $query->execute();
    break;
  }

}

I ended up removing all DB entries for menus and then manually entering them after updating to 8.7
Here's SQL

DELETE FROM menu_tree
 WHERE id LIKE 'menu_link_content:%';

TRUNCATE TABLE menu_link_content;
TRUNCATE TABLE menu_link_content_data;

@nsciacca: Thanks. The update in #11 works but does not remove

s: 10: "views_data";
s: 48: "Drupal\menu_item_extras\MenuLinkContentViewsData";

which is stated in the issue summary.

@demonde You're right. I wasn't getting any specific errors with that handler in place so I didn't investigate further. When the system calls getClassHandler('views_data') on the menu_link_content entity type actually returns 'null' because the class doesn't exist when the menu_item_extras module is uninstalled. We can't remove this handler because there's no remove method, but we can set it to null to remove all traces of the menu_items_extra. Here's an updated function to do so, if you've already run the one above, you can increase the update number and re-run, no harm will be done.

/**
 * Fix for uninstalled Menu Item Extras Class that was left behind.
 */
function mymodule_update_8100() {

  // Load the menu_link_content.entity_type value and modify class.
  $connection = \Drupal::database();
  $query = $connection->select('key_value', 'k');
  $query->condition('k.collection', 'entity.definitions.installed');
  $query->condition('k.name', 'menu_link_content.entity_type');
  $query->fields('k', ['value']);
  $result = $query->execute();

  foreach ($result as $record) {
    $value = unserialize($record->value);

    // Update class if still using menu_item_extras.
    if ($value->getClass() == 'Drupal\menu_item_extras\Entity\MenuItemExtrasMenuLinkContent') {
      $value->setClass('Drupal\menu_link_content\Entity\MenuLinkContent');
      $update = TRUE;
    }

    // Set views_data handler to null if using menu_item_extras.
    $handler_classes = $value->getHandlerClasses();
    if (!empty($handler_classes['views_data']) && $handler_classes['views_data'] == 'Drupal\menu_item_extras\MenuLinkContentViewsData') {
      $value->setHandlerClass('views_data', NULL);
      $update = TRUE;
    }

    // Make SQL call to re-save entity type.
    if (isset($update)) {
      $query = \Drupal::database()->update('key_value');
      $query->fields(['value' => serialize($value)]);
      $query->condition('collection', 'entity.definitions.installed');
      $query->condition('name', 'menu_link_content.entity_type');
      $query->execute();
    }

    break;
  }

}

Thanks, works nice.

This module completely broke all of my menu editing capabilities. There should be a warning about installing this module. I feel I have just lost an entire days work because this module is causing havoc on the menu system and there seems to be no clear way to fix this (easily)

DO NOT INSTALL THIS MODULE - should be a warning on the project page....

Thanks, devarch. #17 fixed it for me. Glad to have a solution!

Hello, I have installed Menu Item Extra module, on drupal 8.7.1 installation, but finally I did my work in a different way so I had to uninstall it.
After unstalling it, I saw an error report on /admin/reports/status

"ENTITY/FIELD DEFINITIONS
Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.
Custom menu link
The View mode field needs to be uninstalled."

I tried many ways to get rid of it, also #17, but nothing...

Any help would be appreciated...

Hello @devarch and thank you,
I've already upgraded to 8.7.2 but the error is still not fixed...
and its very complicated (enormous content and menu items) to start it again...

Really annoyed at this one. I simply tested this module, decided against it, then after uninstalling I have multiple WSOD messages on any menu editing or adding process. In the midst of moving a huge high traffic site from 7 to 8, having a menu items add-on break core menu functionality is the last thing I need or would have expected. This is ridiculous.

Update: Upgraded to 8.7.3, followed #11 in the database, then ran uninstall twice. It failed on first one, succeeded on the second try. I seem to have all menu functionality back now. However, this process did delete a lot of my menu items on the main menu. Easier to rebuild those than fight with it though, at least.

Ok, Menu item extras uninstalled cleanly (I hope), on drupal 8.7.3
with the use of #14 (Thank you nsciacca!) code.
I simply installed the remove_menu_extras.zip custom module based on #14
and the error is gone!

Hi, everyone!
I had added the test coverage for this case. After uninstalling of the module test check entity type definition and expects that classes provided by the module not set.
After running this test locally looks like entity updates on uninstall phase going correct as this issue can't be reproduce now.
As a recommendation how to fix the errors in such case, try to install and uninstall this module again.

i had to

drush config-delete core.entity_form_display.menu_link_content.mie-demo-base-menu.default
drush config-delete core.entity_form_display.taxonomy_term.mie_demo_content.default
drush config-delete core.entity_view_display.menu_link_content.mie-demo-base-menu.banner
drush config-delete core.entity_view_display.menu_link_content.mie-demo-base-menu.default
drush config-delete core.entity_view_display.menu_link_content.mie-demo-base-menu.terms
drush config-delete core.entity_view_display.taxonomy_term.mie_demo_content.default
drush config-delete core.entity_view_mode.menu_link_content.banner
drush config-delete core.entity_view_mode.menu_link_content.terms
drush config-delete field.field.taxonomy_term.mie_demo_content.field_mie_image
drush config-delete field.storage.taxonomy_term.field_mie_image
drush config-delete image.style.mie_demo_teaser
drush config-delete taxonomy.vocabulary.mie_demo_content

the submitted fix did not resolve my problem.
Menu Item Extras Demo Base did not install/uninstall correct. So only resulution for me was to delete active config.
After this update from drupal 8.6.13 to 8.8.0 did work.
switched to en as default on multisite setup.