When replacing an existing menu icon most browsers will keep showing the old icon. The requires a forced cache clear before being able to see the change.

CommentFileSizeAuthor
#4 menu_icons-force_browser_cache_clear-2351345-4.patch1.11 KBnbouhid
#1 menu_icons-force_browser_cache_clear-2351345-1.patch610 bytesklaasvw
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klaasvw’s picture

klaasvw CreditAttribution: klaasvw commented
Status: Active » Needs review
FileSize
menu_icons-force_browser_cache_clear-2351345-1.patch610 bytes

The following patch will add a timestamp query string to the CSS background URL if the icon is updated. This will force the browser to reload the file.

ndobromirov’s picture

ndobromirov CreditAttribution: ndobromirov commented
Assigned: klaasvw » Unassigned
Status: Needs review » Reviewed & tested by the community

Seems like a general solution for the problem.
Tested and it works.

dscl’s picture

dscl CreditAttribution: dscl commented

#1 Works for me.
Thanks!

nbouhid’s picture

nbouhid CreditAttribution: nbouhid commented
FileSize
menu_icons-force_browser_cache_clear-2351345-4.patch1.11 KB

This wasn't working for me. Since the security fix made on Drupal 7.20 (see https://www.drupal.org/drupal-7.20-release-notes) the way the module gets the image path is wrong. So using image_style_path is deprecated (@see https://api.drupal.org/comment/49618#comment-49618).

The following patch solves the issue for me.

nbouhid’s picture

nbouhid CreditAttribution: nbouhid commented
Status: Reviewed & tested by the community » Needs review