Drupal 9 Deprecated Code Report [#3047752]

Problem/Motivation
drupal-check results on commit hash: d473fdbbac980b5435235f53dc2f1f5205e621af

 ------ ---------------------------------------------------
  Line   src/Form/MenuExportForm.php
 ------ ---------------------------------------------------
  66     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Form/MenuImportForm.php
 ------ ---------------------------------------------------
  92     Call to deprecated function drupal_set_message().
  94     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ --------------------------------------------------------------------------------
  Line   tests/src/Functional/MenuExportConfigurationFormTest.php
 ------ --------------------------------------------------------------------------------
         Class Drupal\Tests\menu_export\Functional\Form\MenuExportConfigurationFormTest
         was not found while trying to analyse it - autoloading is probably not
         configured properly.
 ------ --------------------------------------------------------------------------------


 [ERROR] Found 4 errors

Comment	File	Size	Author
#7	Drupal-9-Deprecated-Code-Report-3047752-7.patch	1.66 KB	Akanksha92
#4	Drupal-9-Deprecated-Code-Report-3047752-4.patch	1.69 KB	yogen.prasad
#3	Drupal-9-Deprecated-Code-Report-3047752-3.patch	1.25 KB	yogen.prasad

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 April 2019 at 18:20

arpitr created an issue. See original summary.

Comment #2

yogen.prasad CreditAttribution: yogen.prasad as a volunteer commented 12 April 2019 at 18:20

Assigned:

Unassigned

» yogen.prasad

Comment #3

yogen.prasad CreditAttribution: yogen.prasad as a volunteer commented 12 April 2019 at 18:52

Assigned:	yogen.prasad	» Unassigned
Status:	Active	» Needs review

File	Size
Drupal-9-Deprecated-Code-Report-3047752-3.patch	1.25 KB

Comment #4

yogen.prasad CreditAttribution: yogen.prasad as a volunteer commented 12 April 2019 at 20:29

File	Size
Drupal-9-Deprecated-Code-Report-3047752-4.patch	1.69 KB

Comment #5

jerdavis

Minneapolis, MN

CreditAttribution: jerdavis at Horizontal commented 12 April 2019 at 23:50

Status:

Needs review

» Needs work

+++ b/src/Form/MenuExportForm.php
@@ -63,7 +63,7 @@ class MenuExportForm extends ConfigFormBase {
+    \Drupal::messenger()->addMessage('Menu Items exported successfully','status');

+++ b/src/Form/MenuImportForm.php
@@ -89,9 +89,9 @@ public function submitForm(array &$form, FormStateInterface $form_state)
+      \Drupal::messenger()->addMessage($this->t('Menu(s) @menus not found',['@menus'=>implode(',',$invalidMenus)]),'error');
...
+      \Drupal::messenger()->addMessage($this->t('Menu(s) imported successfully'),'success');

Because these forms extend ConfigFormBase, which extends FormBase, the MessengerTrait should already be added. This means that rather than calling the service, you should be able to use the MessengerTrait and call $this->messenger()->addMessage().