line 48 of menu_editor/me_node_creation/menu_editor_node_creation.inc

CommentFileSizeAuthor
#1 menu_editor-932924.patch3.01 KBmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Needs review
FileSize
menu_editor-932924.patch3.01 KB

patch also takes care of some white space issues.

donquixote’s picture

donquixote CreditAttribution: donquixote commented

The whitespace is a habit of mine. Always want to give the blank lines full indentation.
Is there a documented style rule that handles whitespace? Otherwise I would try to just keep the module consistent.

donquixote’s picture

donquixote CreditAttribution: donquixote commented

For the rest:
I didn't know that list($a,$b) is that strict. Error reporting level? Would it help to put a "@" ?
Your patch looks like a reasonable solution.

That said, I do have a local version somewhere which stores these values in the $form array instead of a static var. Seems like a better idea. I should commit this thing to -dev.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

http://drupal.org/coding-standards#indenting
My editor auto removes trailing whitespace at the end of a line

And if your up for a challenge use this
http://drupal.org/project/coder

donquixote’s picture

donquixote CreditAttribution: donquixote commented

I committed a minimal fix to the 6.x-2.2 stable release.

The local version with hook_nodeapi and more changes will go into 6.x-2.3
This way, people can revert to 6.x-2.2, if 2.3 should cause any unforeseen issues.

donquixote’s picture

donquixote CreditAttribution: donquixote commented
Status: Needs review » Closed (fixed)