Problem/Motivation

User warning: Trying to overwrite a cache redirect with one that has nothing…

Related to upgrade to 10.4 with this change #3452181: VariationCache needs to be more defensive about cache context manipulation to avoid broken redirects

Steps to reproduce

  • Ensure caching is enabled
  • add this system breadcrumb block with this menu_breadcrumbs configured.
  • Visit different pages.

Proposed resolution

Add cachability metadata for route context and add the same code in #3472014: BookBreadcrumbBuilder needs to always set the route.book_navigation cache context for the book module.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork menu_breadcrumb-3495164

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Missing route cachability metadata. » Missing route cachability metadata
Issue tags: +Drupal 10.4 compatibility

joelpittet opened merge request !27

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

This seems to fix the problem for us.

douggreen’s picture

douggreen commented
Status: Needs review » Reviewed & tested by the community

This fixed the problem for us as well. Can we get this merged and a new tag applied?

xurizaemon made their first commit to this issue’s fork.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Reviewed & tested by the community » Fixed

Rebased, tidied and merged, thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.