Hello!

In the #2827653: Render cache should be cleared when menu link or entity is updated I gave you a patch with a bug. Originally your code was testing if there are multiple languages via count($this->languageManager->getLanguages()) > 1. But I proposed to swap it with $this->languageManager->isMultilingual().

I meant to swap it that way, but somehow I overlooked to remove the surrounding count(). So right now it does count($this->languageManager->isMultilingual()) > 1 which is nonsense.

CommentFileSizeAuthor
#2 2840017-multilingual-2.patch573 bytesbucefal91
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bucefal91 created an issue. See original summary.

bucefal91’s picture

Status: Active » Needs review
FileSize
573 bytes

I enclose a very simple patch that takes care of it.

rphair’s picture

good catch, just testing now before commit...

  • rphair committed 0ba4712 on 8.x-1.x authored by bucefal91
    Issue #2840017 by bucefal91, rphair: Incorrect usage of...
rphair’s picture

Assigned: Unassigned » rphair
Status: Needs review » Fixed

tagged a this into a new beta to be sure it's pushed out to multilingual sites...

bucefal91’s picture

Thank you :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.