Notice: Undefined index: parent_mlid in menu_block_get_config() (line 309 of menu_block/menu_block.module.
Notice: Undefined index: parent_mlid in menu_tree_block_data() (line 348 of menu_block/menu_block.module.
Notice: Undefined index: parent_mlid in menu_tree_block_data() (line 379 of menu_block/menu_block.module.
Notice: Undefined index: parent_mlid in menu_tree_block_data() (line 401 of menu_block/menu_block.module.

I'm seeing these messages on every page load in the logs. Nothing seems to be broken. Would this be a case for an isset()?

CommentFileSizeAuthor
#12 interdiff.txt684 bytesdsnopek
#12 menu_block-2642556-11.patch2.84 KBdsnopek
#11 menu_block-2642556-10.patch2.84 KBdsnopek
#7 menu_block-undefined_index-2642556-7.patch2.84 KBgenjohnson
#6 menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-6.patch2.91 KBdbazuin
#4 menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-4.patch2.22 KBdbazuin
#3 menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-2-do-not-test.patch2 KBsourabh.singhal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ponies created an issue. See original summary.

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Assigned: Unassigned » sourabh.singhal
sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Status: Active » Needs review
FileSize
menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-2-do-not-test.patch2 KB

Hi,

I have attached the patch file which fixed the bug. Please review.

Thanks
Sourdrup

dbazuin’s picture

dbazuin CreditAttribution: dbazuin at LimoenGroen commented
Assigned: sourabh.singhal » Unassigned
FileSize
menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-4.patch2.22 KB

After applying the patch from comment 3 the Undefined index in line 379 and 401 where still there.
So I add two more fixes.

Status: Needs review » Needs work

The last submitted patch, 4: menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-4.patch, failed testing.

dbazuin’s picture

dbazuin CreditAttribution: dbazuin at LimoenGroen commented
FileSize
menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-6.patch2.91 KB

I found one more function that sometimes gives a Undefined index so here is a new patch.
The function is template_preprocess_menu_block_wrapper()

genjohnson’s picture

genjohnson CreditAttribution: genjohnson at The University of Iowa commented
Status: Needs work » Reviewed & tested by the community
FileSize
menu_block-undefined_index-2642556-7.patch2.84 KB

The patch in #6 works for me, I've just re-rolled it to apply from the root of the menu_block module instead of the Drupal root.

genjohnson’s picture

genjohnson CreditAttribution: genjohnson at The University of Iowa commented
Status: Reviewed & tested by the community » Needs review

Changing status to "needs review" to trigger tests.

The last submitted patch, 6: menu_block-fixed_Undefined_index_parent_mlid_menu_tree_block_data-2642556-6.patch, failed testing. View results

cboyden’s picture

cboyden CreditAttribution: cboyden at UC Berkeley Web Platform Services commented
Status: Needs review » Needs work

While testing this I saw menu_block errors in the dblog:

Menu block 1 is set to use parent menu link 0 but the menu link was not loadable or does not exist.
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs work » Needs review
FileSize
menu_block-2642556-10.patch2.84 KB

@cboyden I haven't tested this, but I suspect your problem would be fixed by switching from isset() to !empty(). A patch is attached that swaps those.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
menu_block-2642556-11.patch2.84 KB
interdiff.txt684 bytes

It looks like an instance of $config['expanded'] got converted to isset($config['expanded']) when it shouldn't have been (since this issue is just about $config['parent_mlid']