Menu block names get translated twice [#1909366]

  // Get the default block name.
  $menu_names = menu_block_get_all_menus();
  menu_block_set_title(t($menu_names[$config['menu_name']]));

In the shown code the menu names are translated. The problem is that menu_block_get_all_menus() already returns translated strings making a translation of the already translated name.

Comment	File	Size	Author
#4	menu_block-use-i18n-string-translate-for-menu-title-1909366-4.patch	969 bytes	alexverb
#4
#1	menu_block-double_translations_of_menu_names-1909366-1.patch	485 bytes	lund.mikkel
#1
	menu_block-double_translations_of_menu_names.patch	633 bytes	lund.mikkel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lund.mikkel CreditAttribution: lund.mikkel commented 6 February 2013 at 09:30

File	Size
menu_block-double_translations_of_menu_names-1909366-1.patch	485 bytes

Wrong path :S

Comment #2

JohnAlbin

he/they/他

English

Taipei, Taiwan

CreditAttribution: JohnAlbin commented 4 March 2013 at 14:07

Status:

Needs review

» Fixed

Yep. I dug into the underlying function calls. You are correct.

Fixed. http://drupalcode.org/project/menu_block.git/commitdiff/f761d34

Comment #3

18 March 2013 at 14:10

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

alexverb CreditAttribution: alexverb commented 1 August 2013 at 11:49

Status:

Closed (fixed)

» Needs review

File	Size
menu_block-use-i18n-string-translate-for-menu-title-1909366-4.patch	969 bytes

It looks like this is a case of inappropriate use of the t() function. I couldn't get the menu title appear translated in any way. The following patch against 7.x-2.x fixes this issue.

I don't know if menu_get_menus() is in the wrong here but don't have time to dig in to this issue.

Hope this helps...