Hello,

There are errors on the menu_attributes settings when checking the schema with config_inspector.

I will upload a patch.

CommentFileSizeAuthor
#4 2883698-after_patch.png83.74 KBGrimreaper
#4 2883698-before_patch.png78.2 KBGrimreaper
#4 menu_attributes-config_schema-2883698-4.patch805 bytesGrimreaper
#2 menu_attributes-config_schema-2883698-2.patch805 bytesGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Assigned: Grimreaper » Unassigned
Status: Active » Needs review
FileSize
menu_attributes-config_schema-2883698-2.patch805 bytes

Here is the patch.

Thanks for the review.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

Could you provide documentation links or more reason for the change?

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
FileSize
menu_attributes-config_schema-2883698-4.patch805 bytes
2883698-before_patch.png78.2 KB
2883698-after_patch.png83.74 KB

Hello,

Here is a reworked patch. It was not config_entity but config_object that should be used.

Documentation link: https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

More reason for the change: please see the attached screenshots.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

Thanks @Grimreaper that link is helpful for why the change is needed. It's like a special mapping.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs review » Fixed

Committed and pushed.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Thanks @joelpittet for the commit.

Yes you can define new schema types and inherit from those and core provides a lot of "advanced" type.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.