When translate menu item - copy default values from original menu item to newly created

CommentFileSizeAuthor
#3 menu_attributes-2295073-3.patch831 bytesyingtho
#1 menu_attributes-2295703-1.patch760 bytesstubben
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stubben’s picture

stubben CreditAttribution: stubben commented
FileSize
menu_attributes-2295703-1.patch760 bytes
yingtho’s picture

yingtho CreditAttribution: yingtho commented
Status: Active » Needs review
yingtho’s picture

yingtho CreditAttribution: yingtho commented
FileSize
menu_attributes-2295073-3.patch831 bytes

Fix warning when attributes when menu has no attributes.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 7.x-1.0-rc2 » 7.x-1.x-dev
Status: Needs review » Postponed (maintainer needs more info)

Can you explain what this patch is doing? Sorry but I don't follow the goal of this patch.

MediaFormat’s picture

MediaFormat CreditAttribution: MediaFormat commented

It seems to copy the attributes, if any, when a menu item is translated to another language.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Postponed (maintainer needs more info) » Needs work

Thanks @MediaFormat I see what you mean.

+++ b/menu_attributes.module
@@ -214,6 +214,16 @@ function _menu_attributes_form_alter(array &$form, array $item = array(), array
+  if (isset($_GET['translation'])) {
+    $source_item = menu_link_load($_GET['translation']);

Can we avoid checking the _GET argument?

Maybe this should be done on form submission for creating a new translation?