Problem/Motivation
On the status report a Memcached version is shown. This is the version of the php extension installed, not the version of the memcached instance the site it connected to.
Other modules that connect to external services show the version of the running service here.
Steps to reproduce
- Enable the memcache module
- Go to the status report
- See the memcache(d) version
Proposed resolution
Add a small bit of help text here to make it abundantly clear this is the version of the php extension, not the version of the external service.
This is a VERY minor change, but would help people like me that saw no issue on the status report and assumed Memcache was working fine.
Cheers
Tom
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | Screen Shot 2020-09-03 at 3.19.20 pm.png | 25.73 KB | blacklabel_tom |
Issue fork memcache-3168882
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
blacklabel_tom commentedHi,
As an update to this one, I clocked that ElasticSearch does a good job of this:
Cheers
Tom
Comment #5
xurizaemonYeah, this had confused me in the past too; especially if your PHP makes both `memcache` and `memcached` extensions available, you'll see two versions in the status report with no additional context, which might lead to the understandable interpretation that client and server are both shown there. Instead, the user is being shown either one or two PHP extension versions, only one of which will ever be active at a time.
We can do what's proposed in the issue currently - add additional text (as shown in screenshot above) to indicate that this is the version of the extension. It would be nice to also add the server version to the status page, but no need for this issue to wait on that.
Test reports failure on PHPUnit run, but it does not look related to the code changes in this MR.
Comment #6
rosk0Thanks Chris!
The changes look good and make sense.
Pipeline failure is not related to changes here and are addressed in #3538514: Fix tests on 11.2.