When nocookie setting is disabled, protocol is forced to be 'http' causing videos to not load on https sites.

CommentFileSizeAuthor
#8 media_youtube-http_forced_when_nocookie_is_disabled-2883877-8.patch417 bytesbrandonpost
#7 media_youtube-http_forced_when_nocookie_is_disabled-2883877-7.patch999 bytesbrandonpost
#2 media_youtube-http_forced_when_nocookie_is_disabled-2883877.patch406 bytesandyg5000
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andyg5000 created an issue. See original summary.

andyg5000’s picture

andyg5000
he/him
Primary language English
Location North Carolina, USA
CreditAttribution: andyg5000 at Blue Oak Interactive commented
Status: Active » Needs review
FileSize
media_youtube-http_forced_when_nocookie_is_disabled-2883877.patch406 bytes
dasginganinja’s picture

dasginganinja
Primary language English
Location Bethlehem, PA
CreditAttribution: dasginganinja at Lehigh University commented
Status: Needs review » Reviewed & tested by the community

This issue could also be titled "Youtube Embeds stop working on HTTPS"

This fixed the issue I had with 7.x-3.1 as it gives a protocol-less URL for the embeds.

joelstein’s picture

joelstein CreditAttribution: joelstein at On Fire Media commented

Thanks for this patch, we had the exact same problem. This patch resolved it.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch. I'll cut a new release with this asap.

  • andyg5000 authored 728b050 on 7.x-3.x 
    Issue #2883877 by andyg5000: http forced when nocookie is disabled
brandonpost’s picture

brandonpost CreditAttribution: brandonpost as a volunteer commented
FileSize
media_youtube-http_forced_when_nocookie_is_disabled-2883877-7.patch999 bytes

The protocol-less URL was the way this module worked before 3.1, but the forced protocol was added because apparently it was needed to resolve issue #1405528. What if we force https rather than http in order to solve both issues? If someone specifically wants to use http, they could use the protocol_specify option and set the protocol to http.

Here is a patch which I believe accomplishes this.

brandonpost’s picture

brandonpost CreditAttribution: brandonpost as a volunteer commented
FileSize
media_youtube-http_forced_when_nocookie_is_disabled-2883877-8.patch417 bytes

Sorry, there was no need to reorder those if-statements. Here's a simpler patch.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Fixed » Needs review
andyg5000’s picture

andyg5000
he/him
Primary language English
Location North Carolina, USA
CreditAttribution: andyg5000 at Blue Oak Interactive commented

I think #7 + should be a new issue. Either way, I don't see a problem hard coding https since there's an option to overwrite.

  • brandonpost authored 6cf492c on 7.x-3.x 
    Issue #2883877 by brandonpost, andyg5000: http forced when nocookie is...
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed

ok, taking latest patch, should be ok

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.