MediaVimeoStreamWrapper is using HTTP in the base and embed URL's. On sites running HTTPS this causes problem's when file_create_url() is called. The vimeo oEmbed API is not even available on HTTP so we can change that as well.
Proposed solution:
protected $base_url = 'http://vimeo.com'; should be changed to protected $base_url = 'https://vimeo.com';. This is preferred instead of using protocol relative URL's because this could have impact on performance.
This problem occurs in multiple modules that extend the media module. Some of them do use HTTPS instead of HTTP and should be equalized.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | media_vimeo_https-2913855-3.patch | 2.36 KB | steven buteneers |
Comments
Comment #2
steven buteneers commentedComment #3
steven buteneers commentedSupplied patch to use secure protocols. Also updated the MediaInternetVimeoHandler that was still using HTTP for embedding.
Comment #4
steven buteneers commentedComment #5
colorfulcoder commentedSeems legit: Since all the URL's you changed are in domain vimeo.com, and that domain automatically redirects you to https://vimeo.com.
Changing the .json file URL's might be out of scope, but it's an improvement (performance wise) so I think that should be included.
- Tested if the patch rolls -> it does.
- Tested if the patch fixes the problem -> it does.
- Tested if the patch gives any additional bugs -> it doesn't seem to.
- The patch doesn't change anything about coding style, so that still applies.