Thanks for the module, fills in a vital missing piece of the puzzle!
We're trying to bring it into our distribution, LocalGov Drupal, but our automated tests are throwing up missing schema errors.
For example:
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for core.entity_form_display.paragraph.localgov_featured_campaign.default with the following errors: core.entity_form_display.paragraph.localgov_featured_campaign.default:content.localgov_featured_campaign_image.third_party_settings.media_library_edit missing schema
I'll create an issue fork repo and see if I can resolve.
Issue fork media_library_edit-3315757
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Finn Lewis CreditAttribution: Finn Lewis as a volunteer and at Agile Collective for LocalGov Drupal commentedI've not had much joy trying to get this to work.
I've tried the approach from:
https://git.drupalcode.org/project/display_machine_name/-/blob/2.x/confi...
Creating a file, config/schema/media_library_edit.yml with
I've tried the approach from:
https://git.drupalcode.org/project/field_group/-/blob/8.x-3.x/config/sch...
Still we get failures on any phpunit tests that enable modules with entities that make use of the media_library_edit button.
See https://github.com/localgovdrupal/localgov_project/actions/runs/33352863...
Any pointers from anyone that understands schema definition for third_party_settings would be most welcome.
Comment #4
ekes CreditAttribution: ekes at Agile Collective for LocalGov Drupal commentedLooking at the code it's clear this is adding a third party setting to a widget
https://git.drupalcode.org/issue/media_library_edit-3315757/-/blob/76b88...
Looking at Drupal's core configuration you can see here https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/config/schem... that it gives the name
field.widget.third_party.[%key]
tocore.entity_form_display.*.*.*:content.third_party_settings
The third party settings test module gives a good example of this adding the third party setting https://git.drupalcode.org/project/drupal/-/blob/56990e5ff9a7533d47282de... and adding the config https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/fiel...
So we come out with:
it's a string because of the way the configuration is presently actually used. This should be in the issue fork branch.
Comment #5
progga CreditAttribution: progga commentedTested this config file with the config_inspector module. All looks good. Thanks for the fix :)
Comment #7
ahebrank CreditAttribution: ahebrank commentedComment #8
ahebrank CreditAttribution: ahebrank commentedI had to rebase the MR to get it on 3.x -- can someone verify I got the correct version?
Comment #9
Finn Lewis CreditAttribution: Finn Lewis as a volunteer and at Agile Collective for LocalGov Drupal commentedThe merge request looks correct, thanks!
Seem to have lost the commit from ekes though, is that how rebasing works?
Just want to make sure ekes gets the credit, I was scratching my head on this one!
Comment #10
ahebrank CreditAttribution: ahebrank commentedYeah, I noticed that too -- not sure why that happened. Let me see if I can rewrite the author on the last commit.
Comment #12
ahebrank CreditAttribution: ahebrank commentedComment #13
ahebrank CreditAttribution: ahebrank commentedWell, I thought I screwed that up but it looks like credit was assigned properly. Thanks to you both!
Comment #14
Finn Lewis CreditAttribution: Finn Lewis as a volunteer and at Agile Collective for LocalGov Drupal commentedThanks ever so much @ahebrank!
I don't suppose you're up for a cheeky 3.0.1 release to follow up on today's 3.0.0 release are you?
Comment #15
ahebrank CreditAttribution: ahebrank commentedSure thing.