Problem/Motivation

Allow adding additional attributes to iframe element e.g. https://git.drupalcode.org/project/iframe/-/blob/8.x-1.x/src/Plugin/Fiel...

Proposed resolution

Add additional fields to media type when \Drupal\media\MediaSourceBase::submitConfigurationForm() creates source field.

Remaining tasks

Create a patch.
Add tests.
Review.
Rejoice.

User interface changes

UI will allow you to select values for additional iframe attributes.

API changes

API addition.

Data model changes

Additional fields on the media type add/edit form.

CommentFileSizeAuthor
#2 3203570-2.patch758 bytesPooja Ganjage

Comments

jibran created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3203570-2.patch758 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
prudloff’s picture

prudloff commented

The patch does not seem to add a way to set these attributes.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Needs work

Yup, the patch is only adding defaults to the formatter.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Active

Hiding #2 as it is not relevant; resetting issue.

dpi’s picture

dpi
Location Perth, Australia
commented
Title: Add addtional attribute support to iframe element » Add additional attribute support to iframe element
smustgrave’s picture

smustgrave commented

Wonder if this should be closed for #3327390: Support additional attributes in <iframe> tag